Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_compat_test.cpp generates warning since Windows.h brings in conflicting max() macro #579

Closed
helmesjo opened this issue Aug 23, 2023 · 5 comments

Comments

@helmesjo
Copy link
Contributor

Expected Behavior

It compiles fine.

Actual Behavior

boost/ut.hpp(708): warning C4003: not enough arguments for function-like macro invocation 'max'

Steps to Reproduce the Problem

  1. Build master (including tests) with MSVC.

Specifications

  • Version: master (commit 92844cb90f).
  • Platform: Windows
@helmesjo
Copy link
Contributor Author

@kris-jusiak Any possibility to get this fixed and in to a v2.0.1 release? Right now, if building with -WX (warning as error), it gets blocked by this warning.

@kris-jusiak
Copy link
Contributor

Sure @helmesjo, I don't have neither windows nor msvc access, could you please create a PR so we can be sure it's fixed? No issues with releasing 2.0.1 when the fix is in, thanks

@helmesjo
Copy link
Contributor Author

Will do!

@kris-jusiak
Copy link
Contributor

awesome, thanks, will take a look as soon as it's available and release 2.0.1 just after CI passes

@helmesjo
Copy link
Contributor Author

Created PR: #601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants