-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
win_compat_test.cpp
generates warning since Windows.h
brings in conflicting max()
macro
#579
Comments
@kris-jusiak Any possibility to get this fixed and in to a |
Sure @helmesjo, I don't have neither windows nor msvc access, could you please create a PR so we can be sure it's fixed? No issues with releasing 2.0.1 when the fix is in, thanks |
Will do! |
awesome, thanks, will take a look as soon as it's available and release 2.0.1 just after CI passes |
Created PR: #601 |
Expected Behavior
It compiles fine.
Actual Behavior
Steps to Reproduce the Problem
master
(including tests) with MSVC.Specifications
The text was updated successfully, but these errors were encountered: