Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change links in as.families() #25

Open
mayrandy opened this issue Sep 2, 2016 · 3 comments
Open

Change links in as.families() #25

mayrandy opened this issue Sep 2, 2016 · 3 comments
Assignees

Comments

@mayrandy
Copy link
Member

mayrandy commented Sep 2, 2016

It should be possible to use different link functions in families that we import from gamlss via as.families(), currently we are just using the default.

The link function is crucial forngradient, as in gamlss they use the derivatives d l / d mu (in case of the first parameter of the distribution). We need d l / d eta_mu, therefore we also need d mu / d eta_mu which depends on the link.

@mayrandy mayrandy self-assigned this Sep 2, 2016
@hofnerb
Copy link
Member

hofnerb commented Sep 2, 2016

Once the general issue regarding the derivatives is resolved, could we inlclude this also in other families?

We could use link and inverse link functions along the lines of countreg (https://r-forge.r-project.org/scm/viewvc.php/pkg/R/?root=countreg).

@mayrandy
Copy link
Member Author

mayrandy commented Sep 5, 2016

Ok, that was easier than expected. Should work now with a981957 for as.families().

However, @hofnerb is right - we should go through the existing orginal gamboostLSS families and make it possible for users to define other links. In boost-R/mboost#34 I did use stats::make.link() which automatically provides all necessary functions including d mu / d eta via link$mu.eta(f).

@hofnerb
Copy link
Member

hofnerb commented Apr 25, 2017

@mayrandy Is it possible to include the required changes for the gamboostLSS families in the next release in a few days? If so, you should implement the changes in the master branch. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants