Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several Improvements #84

Open
markusgritsch opened this issue Apr 11, 2023 · 1 comment
Open

Several Improvements #84

markusgritsch opened this issue Apr 11, 2023 · 1 comment

Comments

@markusgritsch
Copy link

Hi, I like the concept of bonsai.css very much. Thank you for developing it.

If anyone is interested, I fixed some issues, and added a few things.
https://markusgritsch.github.io/bonsai.css/myindex.html
https://markusgritsch.github.io/bonsai.css/dist/mybonsai.css

image
The switch is an <input type="checkbox" role="switch">

image
The progress and (continuously spinning) busy indicator are new, the input range is a bit tweaked.

image image
The descender cropping and the height of the <select> is fixed.

Despite being disabled="", buttons still reacted to hover and clicking. This is now fixed.

image
Radio buttons properly display the focus border now and check boxes use an SVG check mark because the tick glyph was rendered black on my iPhone 6.

image
image
The grid layout can now be used without class="grid" and I added the grid-auto-flow property to be able to have a responsive auto flow direction.

image image
I added the bullet styling from the markdown book.css.

The @media rule now also affects printing, since printing a page styled for a phone does not look appealing.

The basic grid layouting was missing the xl @media rule.

Some other minor fixes.

Feel free to add some or all changes to your excellent bonsai.css framework.

@markusgritsch markusgritsch changed the title Several improvements Several Improvements Apr 12, 2023
@diomed
Copy link

diomed commented Jun 3, 2023

would be nice if you sent pr to master

btw @_ciar4n is founder, might be good to ask him if he'd co-own this repo or transfer it to you. smth like that.
so it would go on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants