Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default font-size, weight and line-height as CSS variables #73

Open
yvesh opened this issue Aug 31, 2021 · 1 comment
Open

Default font-size, weight and line-height as CSS variables #73

yvesh opened this issue Aug 31, 2021 · 1 comment

Comments

@yvesh
Copy link
Collaborator

yvesh commented Aug 31, 2021

Hey @ciar4n,

i feel the basic font-size, line-height and weight in _body.css should be CSS variables too. Would fit into the general scheme and makes overriding them easier, especially because other elements with rem are related to it.

  font-size: 15px;
  line-height: 1.6;
  font-weight: 400;

to

  font-size: var(--text-size, 15px);
  line-height: var(--text-line-height, 1.6);
  font-weight: var(--text-weight, 400);

You used --text as prefix for the other font related settings, so I used it in this example too.

What do you think?

@ciar4n
Copy link
Contributor

ciar4n commented Sep 7, 2021

Hey @yvesh

Yes that makes sense. We have a variable for the base color so stand to reason to also include them for size, weight and line-height. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants