Expose additional minigame metadata in foreground host activity

[rikkolovescats]

In built-in minigames in Bombsquad, there is additional metadata that gets exposed which may then be accessed through plugins using the foreground host activity object, such as in meteor shower:
https://github.com/efroemling/ballistica/blob/4248540d887340de25e47539fdf567525ae8918e/assets/src/ba_data/python/bastd/game/meteorshower.py#L37-L49

which can be accessed through:

>>> _ba.get_foreground_host_activity().allow_mid_activity_joins
False

Let's also make sure to have these fields in all minigames under plugin manager, so any local plugins that make use of these fields don't break. Such as zombie_horde currently only has the name field:

plugin-manager/plugins/minigames/zombie_horde.py

Lines 826 to 832 in 85e7f68

	# ba_meta export game
	class ZombieHordeCoop(ZombieHorde):
	name = 'Zombie Horde'
	@classmethod
	def get_supported_maps(cls, sessiontype: type[ba.Session]) -> list[str]:

[Freaku17]

If you take a closer look...

I don't think without this ba.TeamGameActivity we can register a minigame...
And it already contains these fields in them...

So I don't believe there's any need to change anything, soooo close issue??

[rikkolovescats]

you're right, but it still seems to be missing the allow_mid_activity_joins field here:

plugin-manager/plugins/minigames/zombie_horde.py

Lines 153 to 166 in 85e7f68

	# ba_meta export game
	class ZombieHorde(ba.TeamGameActivity[Player, Team]):
	name = 'Zombie Horde'
	description = 'Kill walkers for points!'
	scoreconfig = ba.ScoreConfig(label='Score',
	scoretype=ba.ScoreType.POINTS,
	none_is_winner=False,
	lower_is_better=False)
	# Show messages when players die since it's meaningful here.
	announce_player_deaths = True
	@classmethod
	def get_available_settings(

this minigame was only an example, there might be more minigames in plugin manager that i haven't checked yet that maybe missing a few fields, so missing fields would needed be added for those minigames as well

[Freaku17]

you're right, but it still seems to be missing the allow_mid_activity_joins field here:

Which ultimately contains:

[Freaku17]

this minigame was only an example, there might be more minigames in plugin manager that i haven't checked yet that maybe missing a few fields, so missing fields would needed be added for those minigames as well

What I mean is a minigame can't be registered without this ba.TeamGameActivity, so ultimately all minigames does contain these information...

So no need for this "expose additional metadata"

[rikkolovescats]

yep, even still, the defaults may not be what we're looking for; zombie horde game doesn't have allow_mid_activity_joins defined, so the foreground activity will expose the default value which is True which could break any dependant plugins.

such as an AFK auto player remover plugin which doesn't want to remove players in activities that have allow_mid_activity_joins set to False, so that players aren't auto removed in elimination type games even if they're AFK, but such a plugin will still auto remove AFK players in zombie horde since zombie horde will default allow_mid_activity_joins to True which doesn't seem right as players have limited lives in zombie horde similar to elimination minigames.

[Freaku17]

yep, even still, the defaults may not be what we're looking for; zombie horde game doesn't have allow_mid_activity_joins defined, so the foreground activity will expose the default value which is True which could break any dependant plugins.

Okay, and here it's developer's fault since ZombieHorde is like Elimination and shouldn't allow_mid_activity_joins 🤔

I understood, I think only some games will have this issue 👍