Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only consider plugins supported by current game version when notifying new plugins #161

Open
rikkolovescats opened this issue Jul 15, 2023 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers plugin-manager Everything plugin manager

Comments

@rikkolovescats
Copy link
Collaborator

At the moment, we consider all plugins in the repo while showing the new plugin notification screenmesage, here:

babase.app.config["Community Plugin Manager"]["Existing Number of Plugins"] = new_num_of_plugins

babase.app.config["Community Plugin Manager"]["Existing Number of Plugins"] = new_num_of_plugins

Instead, we should only be considering plugins that are supported by the current game version. Otherwise, there are cases when the notify new plugin screenmessage doesn't get shown even when there are new plugins available for our game version.

@rikkolovescats rikkolovescats added bug Something isn't working good first issue Good for newcomers plugin-manager Everything plugin manager labels Jul 15, 2023
@rikkolovescats
Copy link
Collaborator Author

@kingsamurai123 gentle ping, this might interest you 🐱

@kingsamurai123
Copy link
Collaborator

The plugin retrieves the compatible versions itself while checking for new plugins.

key=lambda plugin: plugin.latest_compatible_version.released_on_date,

Doesn't this work?

self._latest_compatible_version = PluginVersion(
self,
(number, info),
tag=self.tag if self.latest_version.number == number else info["commit_sha"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers plugin-manager Everything plugin manager
Projects
None yet
Development

No branches or pull requests

2 participants