Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duet detection seems to fail for relative songs #43

Closed
bohning opened this issue Dec 10, 2022 · 2 comments
Closed

Duet detection seems to fail for relative songs #43

bohning opened this issue Dec 10, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@bohning
Copy link
Owner

bohning commented Dec 10, 2022

If a song has relative timings (#RELATIVE:yes), it seems to be a falsely detected as duet.

@RumovZ
Copy link
Collaborator

RumovZ commented Dec 11, 2022

Do you have an example for a relative song? How do actual duets work with #RELATIVE?
On a related note, should we write relative songs at all or convert them to absolute ones?

@bohning
Copy link
Owner Author

bohning commented Dec 11, 2022

I manually converted all relative songs in the usdb to absolute timings a while ago, so only one recently uploaded song had relative timings (not any longer though, it now has absolute timings). I believe, but am not positive on this, that duets are not possible with relative timings (I can’t remember having seen a duet with relative timings in all those years).

Relative timings are somewhat obsolete/unused, so I would suggest to convert them to absolute timings anyways. However, it is pretty easy to save a song with relative timings - simply save the song in the USDX editor with SHIFT+S instead of S and the resulting file will have relative timings (little known shortcut I guess).

I added it to the longer list of potential cleanup tasks in #20 a while ago.

EDIT: I was right in my assumption that duets with relative timings are not supported. I just tried to save an existing duet with SHIFT+S and get the following error message:
image

@bohning bohning added the bug Something isn't working label Dec 11, 2022
@RumovZ RumovZ closed this as completed in 989d45a Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants