Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"FrozenError: can't modify frozen String" in 2.7 with frozen string literal options #243

Open
anthonykaufman opened this issue Nov 12, 2024 · 2 comments

Comments

@anthonykaufman
Copy link

In the latest gem (1.0.27) I'm getting "FrozenError: can't modify frozen String" in several places in the combine_pdf/renderer. Though I originally encountered this in Ruby 2.5, I can reproduce in 2.7 using the --enable-frozen-string-literal and --debug-frozen-string-literal flags.

I've created some tests which expose and fixed by adding .b to a few literals. I can submit as a PR if that'd be helpful.

@boazsegev
Copy link
Owner

Hi @anthonykaufman ,

I tried reproducing this issue, but as my Ruby version is on 3+, I can't seem to replicate this.

Can you please provide a PR, or a backtrace, to allow me to dig deeper?

Thanks!

@anthonykaufman
Copy link
Author

Sorry, for the slow reply here. Got a little sidetracked with other projects last week. Here's that PR including steps to reproduce:
#244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants