enable more ruffs

postgres_searchindex/exceptions.py

@@ -1,6 +1,6 @@
-class SourceAlreadyRegistered(Exception):
+class SourceAlreadyRegisteredError(Exception):
     pass
 
 
-class SourceNotRegistered(Exception):
+class SourceNotRegisteredError(Exception):
     pass

postgres_searchindex/management/commands/postgres_searchindex_rebuild.py

@@ -5,6 +5,4 @@ class Command(BaseCommand):
     help = "Try send something to Sentry!"
 
     def handle(self, *args, **options):
-        from xxx import yyy  # noqa
-
-        return
+        pass

postgres_searchindex/management/commands/postgres_searchindex_update.py

@@ -15,7 +15,7 @@ def handle(self, *args, **options):
             self.stdout.write(
                 f"Updating index \"{index_key}\" with kwargs {index.get('kwargs', {})}"
             )
-            for source_name, source_cls in source_pool.get_sources().items():
+            for source_cls in source_pool.get_sources().values():
                 source = source_cls(**index.get("kwargs", {}))
                 self.stdout.write(
                     f"{source.model.__name__}. "

postgres_searchindex/source_pool.py

@@ -4,8 +4,8 @@
 
 from postgres_searchindex.base import IndexSource
 from postgres_searchindex.exceptions import (
-    SourceAlreadyRegistered,
-    SourceNotRegistered,
+    SourceAlreadyRegisteredError,
+    SourceNotRegisteredError,
 )
 from postgres_searchindex.models import IndexEntry
 
@@ -37,7 +37,7 @@ def register(self, source):
             )
         source_name = source.__name__
         if source_name in self.sources:
-            raise SourceAlreadyRegistered(
+            raise SourceAlreadyRegisteredError(
                 "Cannot register {!r}, an source with this name ({!r}) is already "
                 "registered.".format(source, source_name)
             )
@@ -66,7 +66,7 @@ def unregister(self, source):
         """
         source_name = source.__name__
         if source_name not in self.sources:
-            raise SourceNotRegistered("The source %r is not registered" % source)
+            raise SourceNotRegisteredError("The source %r is not registered" % source)
         del self.sources[source_name]
 
     def get_sources(self):

pyproject.toml

@@ -13,29 +13,29 @@ select = [
   # isort
   "I",
   # pep8-naming
-  # "N",
+  "N",
   # pyupgrade
-  # "UP",
+  "UP",
   # flake8-2020
   "YTT",
   # flake8-boolean-trap
-  # "FBT",
+  "FBT",
   # flake8-bugbear
-  # "B",
+  "B",
   # flake8-comprehensions
   "C4",
   # flake8-django
   "DJ",
   # flake8-pie
-  # "PIE",
+  "PIE",
   # flake8-simplify
-  # "SIM",
+  "SIM",
   # flake8-gettext
   "INT",
   # pygrep-hooks
-  # "PGH",
+  "PGH",
   # pylint
-  # "PL",
+  "PL",
   # unused noqa
   "RUF100",
   # flake8-print

setup.py

@@ -1,4 +1,3 @@
-# -*- encoding: utf-8 -*-
 """
 Python setup file for the postgres_searchindex app.
 
@@ -36,7 +35,8 @@
 
 def read(fname):
     # read the contents of a text file
-    return open(os.path.join(os.path.dirname(__file__), fname)).read()
+    with open(os.path.join(os.path.dirname(__file__), fname)) as file:
+        return file.read()
 
 
 install_requires = [