Fix NPE #6388
Merged
Fix NPE #6388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems jar.getDirectories() can contain null values, if there is a jar with META-INF/services/subfolder, but META-INF/services itself does not contain any files. In this case the directories() map contains a key for "META-INF/services" but a null value (which is the map which is null here) Signed-off-by: Christoph Rueger <[email protected]> improve test Signed-off-by: Christoph Rueger <[email protected]>
chrisrueger
force-pushed
the
fix-npe-MetaInfService
branch
from
0018516
to
bc89fe5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6387
Seems jar.getDirectories() can contain null values, if there is a jar with META-INF/services/subfolder, but META-INF/services itself does not contain any files. In this case the directories() map contains a key for "META-INF/services" but a null value (which is the map which is null here)