You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Old issue: calculateScore in ChairPaperView determines what score is sent to the backend for each rubric category through the following calculation: (category_weight / 5) * score (score is a number between 1 and 5). However, this poses issues & raises a 400 bad request error when category_weight is not divisible by 5, because an integer is no longer sent back to the backend. We need to find a way to always send back an integer, either via rounding or by changing the way scores are represented on the backend (maybe we score from 1-5 back and do any calculations for a total score on the frontend).
Upon review of this issue, it seems like there are a number of issues with how the data for papers is stored/calculated and it's worth taking more time to work on it:
the function calculateScore (and other similar ones) is copy pasted in multiple files which is pretty ridiculous. Should be a util function
said function should be changed to have more intuitive logic. (Divide score/5 to get a percentage they got, then multiply that by weight - same math, better flow)
we are sending these weird divided by 5 values back to the back end in PaperGradeTable which is also silly. We should just store 1-5 scores and do the fancy calculations in the views.
The text was updated successfully, but these errors were encountered:
Old issue:
calculateScore
inChairPaperView
determines what score is sent to the backend for each rubric category through the following calculation:(category_weight / 5) * score
(score is a number between 1 and 5). However, this poses issues & raises a 400 bad request error whencategory_weight
is not divisible by 5, because an integer is no longer sent back to the backend. We need to find a way to always send back an integer, either via rounding or by changing the way scores are represented on the backend (maybe we score from 1-5 back and do any calculations for a total score on the frontend).Upon review of this issue, it seems like there are a number of issues with how the data for papers is stored/calculated and it's worth taking more time to work on it:
PaperGradeTable
which is also silly. We should just store 1-5 scores and do the fancy calculations in the views.The text was updated successfully, but these errors were encountered: