Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure Position Paper Grade System #729

Open
shaynak opened this issue Feb 2, 2021 · 0 comments
Open

Restructure Position Paper Grade System #729

shaynak opened this issue Feb 2, 2021 · 0 comments

Comments

@shaynak
Copy link
Member

shaynak commented Feb 2, 2021

Old issue: calculateScore in ChairPaperView determines what score is sent to the backend for each rubric category through the following calculation: (category_weight / 5) * score (score is a number between 1 and 5). However, this poses issues & raises a 400 bad request error when category_weight is not divisible by 5, because an integer is no longer sent back to the backend. We need to find a way to always send back an integer, either via rounding or by changing the way scores are represented on the backend (maybe we score from 1-5 back and do any calculations for a total score on the frontend).

Upon review of this issue, it seems like there are a number of issues with how the data for papers is stored/calculated and it's worth taking more time to work on it:

  • the function calculateScore (and other similar ones) is copy pasted in multiple files which is pretty ridiculous. Should be a util function
  • said function should be changed to have more intuitive logic. (Divide score/5 to get a percentage they got, then multiply that by weight - same math, better flow)
  • we are sending these weird divided by 5 values back to the back end in PaperGradeTable which is also silly. We should just store 1-5 scores and do the fancy calculations in the views.
@shaynak shaynak added the bug label Feb 2, 2021
@shaynak shaynak added the starter label Mar 1, 2021
@mathildepm mathildepm changed the title Fix chair paper view so that an integer is always sent back Restructure Position Paper Grade System Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants