Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed sometimes stops responding to taps #7508

Open
gpp-0 opened this issue Jan 20, 2025 · 28 comments
Open

Feed sometimes stops responding to taps #7508

gpp-0 opened this issue Jan 20, 2025 · 28 comments
Labels
bug Something isn't working

Comments

@gpp-0
Copy link
Contributor

gpp-0 commented Jan 20, 2025

Steps to Reproduce

  1. Scroll to the top of any feed
  2. Scroll down slightly
  3. Do a gentle scroll up, and while the scroll still has momentum and the feed is close to the top, do another scroll up to engage the refresh indicator (you don't need to actually trigger a refresh but the bug remains even if you do)
  4. After you release the gesture, the feed is mostly unresponsive to taps until you perform a scroll again

Attachments

buug.webm

What platform(s) does this occur on?

Android

Device Info

Pixel 8

What version of the app are you using?

1.97.0.1

Additional Information

This bug turns up occasionally during normal use, and I'm pretty sure it doesn't only happen in this specific scenario with the pull-to-refresh, but this is the only reliable way I've found to reproduce it. I'm also not sure if it happens on iOS too since I don't have a device to test it with.
I will look into this soon and I'll open a pull request if I end up finding anything

@gpp-0 gpp-0 added the bug Something isn't working label Jan 20, 2025
@gaearon
Copy link
Collaborator

gaearon commented Jan 20, 2025

Thanks!

@catharsis23
Copy link

Having same issue on Android Galaxy S21 5G, Model SM-G991U1.

@nunomgsantos80
Copy link

nunomgsantos80 commented Jan 21, 2025

Having same issue on Android Galaxy S23 +.

Using app Build version: 1.96.6.588; Bundle info: 5090426 (prod); Bundle date: 25012003; Platform: android; Platform version: 34

@gaearon
Copy link
Collaborator

gaearon commented Jan 21, 2025

Is this a new problem or has it been happening before?

@gaearon
Copy link
Collaborator

gaearon commented Jan 21, 2025

Also @gpp-0 does it happen on main?

@catharsis23
Copy link

New issue after a fresh install today. Wasn't happening on Friday when I last used Bluesky (wanted to detox from internet over weekend). Scrolling feels like its straight up not working (scrolling down sometimes scrolls to right for example)

@nunomgsantos80
Copy link

Revert to 1.96.5 and works fine.

@gaearon
Copy link
Collaborator

gaearon commented Jan 21, 2025

OK, the most important thing to figure out is whether this happens on main. It's possible that #7503 fixed this.

@gpp-0
Copy link
Contributor Author

gpp-0 commented Jan 21, 2025

Yeah this happens on the most recent main commit, and it's also been happening for quite a while. I'm not 1000% sure it's the same bug, but this thing where the feed inexplicably stops registering taps until there is a scroll has definitely been popping up for as long as I can remember (at least a year). I don't think it's related to any of the pager stuff
I can definitely reproduce the pull-to-refresh scenario on 1.96.5 and 1.96.3 for example

@gpp-0
Copy link
Contributor Author

gpp-0 commented Jan 21, 2025

Nope, this is an issue with react native's RefreshControl lmao. A plain FlatList with refresh enabled reproduces the issue

@gaearon
Copy link
Collaborator

gaearon commented Jan 21, 2025

Hm, we do seem to be getting a flurry of new reports. So something new might be in play too.

@nokanol45
Copy link

Hm, we do seem to be getting a flurry of new reports. So something new might be in play too.

Yeah, 1.96.6 seems to have introduced an unrelated gesture bug that pretty much made the app unusable, I've even rolled back to 1.96.5 to temporarily avoid it
https://bsky.app/profile/nokanol45.bsky.social/post/3lg7kjilvoc2j

@gpp-0
Copy link
Contributor Author

gpp-0 commented Jan 21, 2025

Created an issue here facebook/react-native#48804

@gaearon
Copy link
Collaborator

gaearon commented Jan 21, 2025

Let's focus this discussion for now on the more general issue (not the refresh thing) as it seems to be more common. I'm not able to reproduce this so we're left with bisecting I guess. Unless someone has specific repro instructions that work reliably.

@gpp-0
Copy link
Contributor Author

gpp-0 commented Jan 21, 2025

I can't reproduce this either, neither on the emulator nor on a real device...

@gpp-0
Copy link
Contributor Author

gpp-0 commented Jan 21, 2025

Perhaps the dx vs dy triggers for the pager scroll changed with callstack/react-native-pager-view#961 (they most likely did whoops) and now it's easier to accidentally engage the pager when you're trying to scroll through the list? Does the issue persist if you try to scroll as perfectly vertically as you can?

@gaearon
Copy link
Collaborator

gaearon commented Jan 21, 2025

Ok what I think happened here is that we shipped 5130d19 (native fix) in 1.96.5 but I didn't realize it. So out of "caution" I reverted it before cutting 1.96.6. But that revert resulted in my JS version of the fix making it into 1.96.6, and not all Androids seem to handle it well. So what we need to do now is to OTA the undoing of the JS version of the fix. And in a future native release we'll re-include the native fix.

However this theory means that the issue people are running into is assumed to be fixed on main. Unfortunately I can't verify this because my device doesn't repro it.

@gaearon
Copy link
Collaborator

gaearon commented Jan 21, 2025

For folks with this issue, what phone models do you have?

@gpp-0
Copy link
Contributor Author

gpp-0 commented Jan 21, 2025

Ok I managed to reproduce this. For me it happens when I long press on anything and then without releasing try to scroll vertically. That activates the pager instead and it sounds like what's being reported.
It seems to be fixed on the main branch!

@nokanol45
Copy link

For folks with this issue, what phone models do you have?

issue is reproducible on my Samsung Galaxy S10 running Android 12 One UI 4.1. However on my Galaxy Tab S8+ running Android 14 One UI 6.1.1 I can't repro the issue

@mbevc1
Copy link

mbevc1 commented Jan 21, 2025

Same here on S20 as well, feed sometimes doesn't scroll after yesterday's update!

@nunomgsantos80
Copy link

Hi, any news?

@gaearon
Copy link
Collaborator

gaearon commented Jan 21, 2025

We’re planning to send an OTA fix today and also submit a new version.

@gibranparvez
Copy link

Have this on the Galaxy S22 as well

@gaearon
Copy link
Collaborator

gaearon commented Jan 21, 2025

Alright, actually the fix is supposed to have been OTA’d. So if you restart the app a few times you should get it.

To verify if you got it, your Settings > About should say caa1ae5762.

@pjconnors
Copy link

I think the OTA push has fixed the issue on my device. Thanks!

@mbevc1
Copy link

mbevc1 commented Jan 21, 2025

Seems to work here as well on S20, thanks!

btw, version show: caa1ae576 (without 2 at the end 😉 )

@gaearon
Copy link
Collaborator

gaearon commented Jan 21, 2025

OK great. Let’s keep this issue open for the original report related to the refresh gesture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

8 participants