-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feed sometimes stops responding to taps #7508
Comments
Thanks! |
Having same issue on Android Galaxy S21 5G, Model SM-G991U1. |
Having same issue on Android Galaxy S23 +. Using app Build version: 1.96.6.588; Bundle info: 5090426 (prod); Bundle date: 25012003; Platform: android; Platform version: 34 |
Is this a new problem or has it been happening before? |
Also @gpp-0 does it happen on |
New issue after a fresh install today. Wasn't happening on Friday when I last used Bluesky (wanted to detox from internet over weekend). Scrolling feels like its straight up not working (scrolling down sometimes scrolls to right for example) |
Revert to 1.96.5 and works fine. |
OK, the most important thing to figure out is whether this happens on |
Yeah this happens on the most recent main commit, and it's also been happening for quite a while. I'm not 1000% sure it's the same bug, but this thing where the feed inexplicably stops registering taps until there is a scroll has definitely been popping up for as long as I can remember (at least a year). I don't think it's related to any of the pager stuff |
Nope, this is an issue with react native's RefreshControl lmao. A plain FlatList with refresh enabled reproduces the issue |
Hm, we do seem to be getting a flurry of new reports. So something new might be in play too. |
Yeah, 1.96.6 seems to have introduced an unrelated gesture bug that pretty much made the app unusable, I've even rolled back to 1.96.5 to temporarily avoid it |
Created an issue here facebook/react-native#48804 |
Let's focus this discussion for now on the more general issue (not the refresh thing) as it seems to be more common. I'm not able to reproduce this so we're left with bisecting I guess. Unless someone has specific repro instructions that work reliably. |
I can't reproduce this either, neither on the emulator nor on a real device... |
Perhaps the dx vs dy triggers for the pager scroll changed with callstack/react-native-pager-view#961 (they most likely did whoops) and now it's easier to accidentally engage the pager when you're trying to scroll through the list? Does the issue persist if you try to scroll as perfectly vertically as you can? |
Ok what I think happened here is that we shipped 5130d19 (native fix) in 1.96.5 but I didn't realize it. So out of "caution" I reverted it before cutting 1.96.6. But that revert resulted in my JS version of the fix making it into 1.96.6, and not all Androids seem to handle it well. So what we need to do now is to OTA the undoing of the JS version of the fix. And in a future native release we'll re-include the native fix. However this theory means that the issue people are running into is assumed to be fixed on main. Unfortunately I can't verify this because my device doesn't repro it. |
For folks with this issue, what phone models do you have? |
Ok I managed to reproduce this. For me it happens when I long press on anything and then without releasing try to scroll vertically. That activates the pager instead and it sounds like what's being reported. |
issue is reproducible on my Samsung Galaxy S10 running Android 12 One UI 4.1. However on my Galaxy Tab S8+ running Android 14 One UI 6.1.1 I can't repro the issue |
Same here on S20 as well, feed sometimes doesn't scroll after yesterday's update! |
Hi, any news? |
We’re planning to send an OTA fix today and also submit a new version. |
Have this on the Galaxy S22 as well |
Alright, actually the fix is supposed to have been OTA’d. So if you restart the app a few times you should get it. To verify if you got it, your Settings > About should say |
I think the OTA push has fixed the issue on my device. Thanks! |
Seems to work here as well on S20, thanks! btw, version show: |
OK great. Let’s keep this issue open for the original report related to the refresh gesture. |
Steps to Reproduce
Attachments
buug.webm
What platform(s) does this occur on?
Android
Device Info
Pixel 8
What version of the app are you using?
1.97.0.1
Additional Information
This bug turns up occasionally during normal use, and I'm pretty sure it doesn't only happen in this specific scenario with the pull-to-refresh, but this is the only reliable way I've found to reproduce it. I'm also not sure if it happens on iOS too since I don't have a device to test it with.
I will look into this soon and I'll open a pull request if I end up finding anything
The text was updated successfully, but these errors were encountered: