Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bookmarks/ability to ‘save’ posts #1091

Open
ChronicleFlask opened this issue Aug 2, 2023 · 23 comments
Open

Bookmarks/ability to ‘save’ posts #1091

ChronicleFlask opened this issue Aug 2, 2023 · 23 comments
Labels
feature-request A request for a new feature x:discussing We've seen the request and we're talking about it!

Comments

@ChronicleFlask
Copy link

Is your feature request related to a problem? Please describe.

I’d like to be able to ‘save’ posts to come back to later, without needing to publicly ‘like’ or reskeet them.

Describe the solution you'd like

In Twitter it was the bookmark feature. I’d like something like that here. It was incredibly useful.

Describe alternatives you've considered

Taking a screenshot and searching for the text string later. Which… is the clunkiest of solutions!
@ChronicleFlask ChronicleFlask added the feature-request A request for a new feature label Aug 2, 2023
@mschwendener
Copy link

I agree

(as does https://bsky.app/profile/yilinwriter.bsky.social/post/3k4i46zmh5l2q )

@mschwendener mschwendener mentioned this issue Aug 31, 2023
Open
@SaySayTakamura SaySayTakamura mentioned this issue Sep 26, 2023
Open
@pfrazee pfrazee added the x:discussing We've seen the request and we're talking about it! label Sep 26, 2023
@middleone20
Copy link

I also think this would be a great add. Besides Twitter/X, ActivityPub-based apps such as Mastodon also support this feature.

@mschwendener mschwendener mentioned this issue Apr 4, 2024
Open
@danninov
Copy link
Contributor

danninov commented Jun 9, 2024

In surge of new Indonesian user this week, many user asking of bookmark feature. While there's workaround by using feed (like feed by Jaz), it would be nice to have native bookmark feature on bsky.

@saltedlolly
Copy link

Is this planned?

@tvanantwerp
Copy link

I'm curious what would be involved in creating this feature. Wouldn't it be possible to just duplicate the "Like" lexicons and app functionality? A bookmark is effectively the same thing, right? Just a user marking some post, and then being able to see a feed of those marked posts later.

@LovingNumbers
Copy link

I'm curious what would be involved in creating this feature. Wouldn't it be possible to just duplicate the "Like" lexicons and app functionality? A bookmark is effectively the same thing, right? Just a user marking some post, and then being able to see a feed of those marked posts later.

then the bookmark would be public which most wouldn't like (likes on bluesky r public even when the app itself doesn't show it)

@ChronicleFlask
Copy link
Author

I'm curious what would be involved in creating this feature. Wouldn't it be possible to just duplicate the "Like" lexicons and app functionality? A bookmark is effectively the same thing, right? Just a user marking some post, and then being able to see a feed of those marked posts later.

then the bookmark would be public which most wouldn't like (likes on bluesky r public even when the app itself doesn't show it)

Yes: I want private bookmarks. We already have a form of public bookmarking in the form of feeds that look for a certain emoji response (I use one that looks for the pin). But that means everyone can see what I’ve bookmarked, and sometimes you really don’t want to broadcast that to everyone, for various reasons.

@edesdan
Copy link

edesdan commented Oct 21, 2024

I would love private bookmarks as well. Also bookmarking starter kit would be very cool feature.

@Apex-DE
Copy link

Apex-DE commented Oct 23, 2024

private Bookmarks are really missing within the app. Please implement.

@duanemoody
Copy link

duanemoody commented Oct 24, 2024 •
edited
Loading

Browsing the repo this looks like a matter of duplicating Likes except making it a method on .repo instead to ensure it's private (and to speed up response time by not having to filter everyone's bookmarks for one user). I take it rkey is the post's unique ID within the poster's posts but not necessary a GUID (discussions suggest it enforces no particular scheme beyond length)?

Also, is there a particular reason each post's ${profile}/${rkey} is only exposed to HTML inside a hidden A's href and never as metadata like a data- attribute? I'm not complaining, I'm curious.

@theAdhocracy
Copy link

Adding support, particularly if this outputs to an accessible feed. I use Mastodon's bookmark feature to effectively send content directly to Read Later apps like Readwise, Pocket, etc. Now looking for a way to replicate that behaviour with BlueSky, but currently not finding anything that works. This would hopefully solve that use case, too.

@AlexProber
Copy link

There is an external solution for this issue called Dewey: https://getdewey.co/
It is integrated within Bluesky and solves the problem for those that are interested in having private or public bookmarks.

@davidcelis
Copy link

davidcelis commented Nov 17, 2024 •
edited
Loading

I agree that Bluesky needs native support for bookmarks; this is a feature that people have come to expect from social networks like this. The 📌 feed is an interesting workaround, but this post from @pfrazee makes me worry about the workarounds being what enter into the codebase for the social app rather than protocol-level support for bookmarks. I also think it has to be part of the protocol itself instead of just the social app because people will expect their bookmarks to be viewable from any device or from the web, meaning the app shouldn't be storing them as separate state.

Looking through the lexicons, I'm not sure it's as simple as duplicating Likes except making it a method on .repo; as far as I can tell, most com.atproto.repo procedures do not require auth, including com.atproto.repo.getRecord. I may be misunderstanding whether or not repo records can truly be public or private, but it seems that all records are meant to be public.

It feels more like duplicating mutes would work well for bookmarks, but I wasn't sure if there was any existing package within the app.bsky namespace that makes sense (mutes are in app.bsky.graph, but bookmarks aren't really a social graph concern). I thought app.bsky.actor or com.atproto.server might make sense, but the former seems very focused on user settings and onboarding and the latter with credentials. Maybe we need a new small app.bsky.bookmark package for this that follows the similar "require auth, only create and enumerate records for the actor" pattern present for mutes?

@duanemoody
Copy link

duanemoody commented Nov 18, 2024 via email

@surfdude29 surfdude29 mentioned this issue Nov 20, 2024
Open
@ktotten
Copy link

ktotten commented Nov 20, 2024

Adding my vote to have this feature!

@Tamschi Tamschi mentioned this issue Nov 21, 2024
Open
@davidcelis
Copy link

Given the possibility that this should be implemented in the protocol itself, I'd suggest folks weigh in on the discussion in the atproto repo instead of this social-app issue: bluesky-social/atproto#2000

@duanemoody
Copy link

duanemoody commented Nov 22, 2024 via email

@michaelvcolianna michaelvcolianna mentioned this issue Nov 29, 2024
Open
@ebwinters
Copy link

ebwinters commented Dec 20, 2024 •
edited
Loading

The initial work at the lexicon and now client level is being done by myself and members of the lexicon-community org.
here is the recently merged lexicon
here is a draft of a client package for consumption in Bluesky or other app views

I could use some help doing the UI implementation in Bluesky, but the POC is done
image

If anyone on this thread can help with the UI work hit me up @western-red-cedar.bsky.social!

@danielbayley
Copy link

If anyone on this thread can help with the UI work hit me up @western-red-cedar.bsky.social!

@ebwinters See #7231 (comment). Bookmark icons should be ready to go… I don't have time to delve into the codebase proper though, at the moment…

@ebwinters
Copy link

thanks @danielbayley! iconography is like half the battle in my mind. I don't know what design system they're using but it seems these fit

@mimonelu
Copy link

FYI: I have developed a similar bookmarking feature in my personal client . You can try out the UX.
PDSls: https://pdsls.dev/at/did:plc:ilxxgyz7oz7mysber4omeqrg/space.aoisora.bookmark/3ldncin7co22o

localhost_5173_(1440 x 900)

@SharpMars
Copy link

this looks like the main issue for this, so i wanted to say that when bookmarks get added it would be nice if bookmarks view could be paginated
this would make it easier to search through all of them, so for example it wouldnt require you to scroll all the way to get to some post that was bookmarked some time ago
so basically this would make things more convenient

@ebwinters
Copy link

ebwinters commented Jan 7, 2025 •
edited
Loading

i do agree but that isn't how any of the current experiences are loaded (infinte scroll). Unsure how the team will take moving off that pattern

here is an update on development from localhost!
image

@surfdude29 surfdude29 mentioned this issue Jan 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A request for a new feature x:discussing We've seen the request and we're talking about it!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests