Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: libs: commonwealth: We should remove dependency links and move to PEP 508 https://peps.python.org/pep-0508/ #2980

Open
1 task done
JoaoMario109 opened this issue Nov 3, 2024 · 0 comments
Labels
core Issue related to BlueOS-core enhancement New feature or request triage Needs triage from developers

Comments

@JoaoMario109
Copy link
Collaborator

Current behaviour

The --process-dependency-links was removed in PIP 19.0 so if some extension wants to install commonwealth by example, it needs to specify its dependency links as part of its own setup.py like:

setup(
    name="my_extension",
    version="0.1.0",
    license="MIT",
    install_requires=[
        ........
        # This is needed for commonwealth since PIP does not fetch dependency link automatically
        "pykson @ https://github.com/patrickelectric/pykson/tarball/1.0.2#egg=pykson-1.0.2",
        "commonwealth @ https://github.com/bluerobotics/BlueOS/archive/refs/tags/1.3.0.tar.gz#subdirectory=core/libs/commonwealth",
    ],
)

Expected or desired behaviour

Extension should only include commonwealth as a dependency and it should automatically resolve its sub dependencies needed.

Prerequisites

  • I have checked to make sure that a similar request has not already been filed or fixed.
@JoaoMario109 JoaoMario109 added enhancement New feature or request core Issue related to BlueOS-core ui User Interface feature triage Needs triage from developers labels Nov 3, 2024
@JoaoMario109 JoaoMario109 changed the title core: libs: commonwealth: We should remove dependency links and move to [PEP 508](https://peps.python.org/pep-0508/) core: libs: commonwealth: We should remove dependency links and move to PEP 508 https://peps.python.org/pep-0508/ Nov 3, 2024
@JoaoMario109 JoaoMario109 removed the ui User Interface feature label Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issue related to BlueOS-core enhancement New feature or request triage Needs triage from developers
Projects
None yet
Development

No branches or pull requests

1 participant