fix: space in the shared url #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
due to the id directly taking in the spaces from the names, the link shared is containing space in between '%20'. This commit replaces all the spaces with underscore character in the chapter id.
erickzanardo
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110
due to the id directly taking in the spaces from the names, the link shared is containing space in between '%20'. This commit replaces all the spaces with underscore character in the chapter id.
Just adding the
replaceAllmethod to change%20) in links to_works good when both sharing and opening the link (as it is the identifier of that chapter).PS: Tests are failing even before this commit.