Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cart lists shipping costs although summary_total_only is set to False #56

Open
frisi opened this issue Jun 23, 2015 · 4 comments
Open

Comments

@frisi
Copy link
Contributor

frisi commented Jun 23, 2015

If I set IShopCartSettings.summary_total_only I'd expect the cart-portlet and the @@cart view to only show the total.
Currently, if you set free_shipping_limit and flat_shipping_cost to 0, the shipping costs are still listed.

If we set summary_total_only to False net and included vat is listed, as well as shipping costs
portlet:
cart-portlet-without
cart:
cart-not-only-summary

If we set summary_total_only to True the net and included vat is not listed, but the shipping costs are still listed:
portlet:
cart-only-summary1
cart:
cart-portlet-with

@frisi
Copy link
Contributor Author

frisi commented Jun 23, 2015

in version 0.5 i used the setting include_shipping_costs that has been removed in the meantime.
https://github.com/bluedynamics/bda.plone.cart/blob/0.5/src/bda/plone/cart/browser/__init__.py#L53

our use-case:
computation of shipping costs is too complex (depends on weight, country to ship to, phase of the moon, etc) so we simply add a note to the checkout form that shipping costs will be put on the recipe (see screenshots above)
displaying shipping costs: 0 is misleading in this case.

two possible solutions:

A)
I'd make the display of the shipping costs also depend on IShopCartSettings.summary_total_only

B)
alternatively, I'd add a new setting IShopCartSettings.hide_shipping_costs if you guys need a more fine grained solution.
this would simply not list the shipping costs in the cart and checkout form

@frisi
Copy link
Contributor Author

frisi commented Jun 24, 2015

@rnixx , @jensens, @agitator and others using this package:
please tell me what you do thinks about the idea to also hide shipping costs in case IShopCartSettings.summary_total_only is set to True

@ezvirtual
Copy link

Hi @frisi and all, did you end up proceeding with this line of thinking at all? It does seem sensible to have optionally hide shipping costs as per your use case outlined above.

@rnixx
Copy link
Member

rnixx commented Oct 21, 2015

Basically it's a good idea to have the possibility to hide shipping costs. I would prefer to have it as separate option, thus introduce IShopCartSettings.hide_shipping_costs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants