Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Most expected interfaces should be optional #31

Open
rnixx opened this issue Sep 1, 2014 · 1 comment
Open

Most expected interfaces should be optional #31

rnixx opened this issue Sep 1, 2014 · 1 comment
Labels
enhancement

Comments

@rnixx
Copy link
Member

rnixx commented Sep 1, 2014

Currently it's necessary to implement most shop related functionality providing interfaces in order to make things work. In future, things should be more flexible, like so:

Mandatory for buyables:

  • bda.plone.cart.interfaces.ICartItemDataProvider

Optional for buyables:

  • bda.plone.cart.interfaces.ICartItemStock
  • bda.plone.shipping.interfaces.IShippingItem
  • bda.plone.orders.interfaces.ITrading
  • bda.plone.shop.interfaces.IBuyablePeriod

Optional on any content:

  • bda.plone.orders.interfaces.IItemNotificationText
  • bda.plone.orders.interfaces.IGlobalNotificationText
@jensens
Copy link
Member

jensens commented Sep 1, 2014

  • fixed in bda.plone.orders for ITrading and IShippingItem
  • fixed in bda.plone.cart for IShippingItem (also no ITrading was used there)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jensens @rnixx