Ledger Donjon code review

[adrienlacombe]

• Uncomment the line

  LedgerHQ-app-plugin-poap/src/handle_init_contract.c

  Line 14 in 74e54af

  // msg->result = ETH_PLUGIN_RESULT_ERROR;

• Add a return statement after the line

  LedgerHQ-app-plugin-poap/src/handle_init_contract.c

  Line 30 in 74e54af

  msg->result = ETH_PLUGIN_RESULT_UNAVAILABLE;

• Seems that these lines are not necessary remove them if so

  LedgerHQ-app-plugin-poap/src/handle_provide_parameter.c

  Lines 44 to 55 in 74e54af

  	if (context->skip) {
  	// Skip this step, and don't forget to decrease skipping counter.
  	context->skip--;
  	} else {
  	if ((context->offset) && msg->parameterOffset != context->checkpoint + context->offset) {
  	PRINTF("offset: %d, checkpoint: %d, parameterOffset: %d\n",
  	context->offset,
  	context->checkpoint,
  	msg->parameterOffset);
  	return;
  	}
  	context->offset = 0; // Reset offset

• The following line seems to be useless

  LedgerHQ-app-plugin-poap/src/handle_query_contract_ui.c

  Line 30 in 74e54af

  bool token_not_found = !context->token_id;

  it will always be evaluated token_not_found=false
• There is no need to check context->selectorIndex == MINT_TOKEN in

  LedgerHQ-app-plugin-poap/src/handle_query_contract_ui.c

  Line 41 in 74e54af

  if (!token_not_found && context->selectorIndex == MINT_TOKEN) {

  Since this value is only set in the contract initiation
• The following definitions should be removed since they are not used:

1. LedgerHQ-app-plugin-poap/src/poap_plugin.h

   Line 42 in 74e54af

   char ticker[MAX_TICKER_LEN];

2. LedgerHQ-app-plugin-poap/src/poap_plugin.h

   Lines 45 to 48 in 74e54af

   	uint16_t offset;
   	uint16_t checkpoint;
   	uint8_t skip;
   	uint8_t decimals;

3. LedgerHQ-app-plugin-poap/src/poap_plugin.h

   Line 50 in 74e54af

   uint8_t tokens_found;

4. LedgerHQ-app-plugin-poap/src/poap_plugin.h

   Line 23 in 74e54af

   FROM_ADDRESS,

5. LedgerHQ-app-plugin-poap/src/poap_plugin.h

   Line 30 in 74e54af

   FROM_ADDRESS_SCREEN,

6. LedgerHQ-app-plugin-poap/src/poap_plugin.h

   Line 9 in 74e54af

   #define TOKEN_FOUND 1 << 1

• When I run the test its not successful. The tests only cover nano S and nano X. Why is nano S plus not covered?
• Also would be nice to add to the readme which contract the plugin refers to