Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit: Added Trello URL in README.md #128

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

tsaihuangsd
Copy link

@tsaihuangsd tsaihuangsd commented Dec 10, 2018

Trello Set Up:

  • Create a Trello account if you don't have one already
  • Create a new board called "LambdaMUD - {Your Name}"
  • Create lists titled backlog,To Do, In Progress, and Done
  • Fill in the To Do list with the MVP features listed below
  • Fill in the backlog list with all the extra features listed below
  • Share your board with the project manager that has been assigned to you. If you have not been assigned yet, reach out to your lead PM for guidance
  • Add your Trello URL to your project's README.md file. Commit the change, push it to your repository & submit a pull request

https://trello.com/b/6Sp67zaD/lambdamud-tsai

MVP Features:

Client

  • Create a standalone frontend app that communicates with the server via API calls
  • Be able to create a new account on the server (implemented on server)
  • Be able to log in to the server (implemented on server)
  • Create an interface that displays the current room name, its description and the other players in the room
  • Be able to move between rooms and update the display accordingly (implemented on server)
  • Be able to use a say command to say things that other people in the room will see (server implementation incomplete)
  • Upon login, subscribe to a Pusher channel based on the player's universally unique id: p-channel-<uuid>
  • Bind the player channel to broadcast events and display the messages to the player
  • Alert the player when someone enters and leaves the current room (implemented on server)
  • Alert the player when someone in the current room says something (server implementation incomplete)

Server

  • Create a new API endpoint for say which broadcasts a message to other players in the current room
  • Deploy to Heroku

General

  • Header comments in all source files that describe overall what the file does
  • Header comments on all functions that describe what the function does, function arguments, and return values

Copy link

@TheDeterminator TheDeterminator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tsai, truly awesome job with this project. You did a great job documenting your code with frequent, detailed commits and adding your trello link. You also thought deeply about how to implment various parts of this project. Great work. One thing I suggest is to format your PRs in the form "FirstName LastName - Name-Of-Project" to make it easier for your PM to find. Overall, great work!

@@ -41,6 +41,8 @@ creative guide.
- [ ] Share your board with the project manager that has been assigned to you. If you have not been assigned yet, reach out to your lead PM for guidance
- [ ] Add your Trello URL to your project's README.md file. Commit the change, push it to your repository & submit a pull request

https://trello.com/b/6Sp67zaD/lambdamud-tsai

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that you put your trello link in here. It's a small thing but a lot of students forget to do this, but it's really important for communicating your work so great job.


urlpatterns = [
path('admin/', admin.site.urls),
path('api/', include('api.urls')),
path('api/adv/', include('adventure.urls')),
re_path(r'^api-token-auth/', views.obtain_auth_token)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice how you implemented an authentication route here.

player_uuid = player.uuid
player_id = player.id
data = json.loads(request.body)
message = data['message']

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a small thing, but have you thought about how you might handle the case where a user submits a blank message or a malicious code? It's definitely stretch but it could interesting to think about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants