Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Contract Score #1462

Closed
tgladilina opened this issue Dec 25, 2023 · 1 comment · Fixed by #1468
Closed

Update: Contract Score #1462

tgladilina opened this issue Dec 25, 2023 · 1 comment · Fixed by #1468
Assignees
Labels
v1.22.0 Release v1.22.0

Comments

@tgladilina
Copy link
Collaborator

  1. please update colors for light and dark themes:

Security score is GREAT

  • gray border color for all scores
  • green 600 (light) green 400 (dark)

Image

Security score is LOW

  • gray border color for all scores
  • purple 600 (light) purple 400 (dark)

Image

Security score is Critical

  • gray border color for all scores
  • red 600 (light) red 400 (dark)

Image

  1. Could we show the loader for a score?

Image

Figma file:
https://www.figma.com/file/4In0X8UADoZaTfZ34HaZ3K/Blockscout_2.0?type=design&node-id=15393-98948&mode=design

@isstuev
Copy link
Collaborator

isstuev commented Jan 2, 2024

2 - we don't know if a contract has a score or not, so if we replace our skeleton with that loader -- idk how to process the case with empty response or method error

@isstuev isstuev self-assigned this Jan 2, 2024
@github-actions github-actions bot added pre-release Tasks in pre-release right now v1.22.0 Release v1.22.0 and removed pre-release Tasks in pre-release right now labels Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.22.0 Release v1.22.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants