Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest blocks layout issue #1189

Closed
nnlgsakib opened this issue Sep 16, 2023 · 14 comments · Fixed by #1205
Closed

Latest blocks layout issue #1189

nnlgsakib opened this issue Sep 16, 2023 · 14 comments · Fixed by #1205
Assignees
Labels
bug Something isn't working v1.12.0 Release v1.12.0

Comments

@nnlgsakib
Copy link
Member

nnlgsakib commented Sep 16, 2023

Description

Screenshot_2023-09-16-20-41-49-87_40deb401b9ffe8e1df2f1cc5ba480b12

validator addr is crossing the block box

Link to the page

https://mainnet.mindscan.info

Steps to reproduce

You can check it at homepage

App version

v1.2.0

Browser

No response

Operating system

None

Additional information

No response

@nnlgsakib nnlgsakib added bug Something isn't working triage Issues and PRs that are needed triage labels Sep 16, 2023
@tom2drum
Copy link
Collaborator

Can you share the list of ENV variable values that are used for running the app? And also could you update the app version to the latest one?

@ekawibisono
Copy link

Hi bro @nnlgsakib
I think you have to check your backend, does your backend block also display the address 0x000000000000000000000 ?

@nnlgsakib
Copy link
Member Author

Hi bro @nnlgsakib I think you have to check your backend, does your backend block also display the address 0x000000000000000000000 ?

No

BS v1 : http://v2.mindscan.info:3000/

@nnlgsakib
Copy link
Member Author

nnlgsakib commented Sep 20, 2023

Can you share the list of ENV variable values that are used for running the app? And also could you update the app version to the latest one?

Yes I have updated to the latest version and

my env vars https://raw.githubusercontent.com/nnlgsakib/media/main/.env

@ekawibisono
Copy link

Hi bro @nnlgsakib I think you have to check your backend, does your backend block also display the address 0x000000000000000000000 ?

No

BS v1 : http://v2.mindscan.info:3000/

in your backend, address miner or validator not show
image

in your env backend, BLOCK_TRANSFORMER your setting what ? base or clique ?

@tom2drum
Copy link
Collaborator

my env vars https://raw.githubusercontent.com/nnlgsakib/media/main/.env

@nnlgsakib thanks. Confirm, that is a bug, we will try to fix it in the next release. Stay tuned.

@tom2drum tom2drum changed the title Block box issu Latest blocks layout issue Sep 20, 2023
@tom2drum tom2drum removed the triage Issues and PRs that are needed triage label Sep 20, 2023
@tom2drum tom2drum self-assigned this Sep 20, 2023
@nnlgsakib
Copy link
Member Author

my env vars https://raw.githubusercontent.com/nnlgsakib/media/main/.env

@nnlgsakib thanks. Confirm, that is a bug, we will try to fix it in the next release. Stay tuned.

NEXT_PUBLIC_VIEWS_BLOCK_HIDDEN_FIELDS=["burnt_fees","total_reward"]

I noticed that after removing this env var everything is back to normal. That means there is a problem here

@nnlgsakib
Copy link
Member Author

Hi bro @nnlgsakib I think you have to check your backend, does your backend block also display the address 0x000000000000000000000 ?

No
BS v1 : http://v2.mindscan.info:3000/

in your backend, address miner or validator not show image

in your env backend, BLOCK_TRANSFORMER your setting what ? base or clique ?

Base!

@ekawibisono
Copy link

ekawibisono commented Sep 20, 2023

I Think not bug, check this i build frontend and show address. @tom2drum @nnlgsakib

i think in your backend update env this BLOCK_TRANSFORMER=base to BLOCK_TRANSFORMER=clique

But what client node are you using? @nnlgsakib

image

@nnlgsakib
Copy link
Member Author

nnlgsakib commented Sep 20, 2023

I Think not bug, check this i build frontend and show address. @tom2drum @nnlgsakib

i think in your backend update env this BLOCK_TRANSFORMER=base to BLOCK_TRANSFORMER=clique

But what client node are you using? @nnlgsakib

using polygon-edge

and its a bug
please check it
#1189 (comment)

@ekawibisono
Copy link

ekawibisono commented Sep 20, 2023

I Think not bug, check this i build frontend and show address. @tom2drum @nnlgsakib
i think in your backend update env this BLOCK_TRANSFORMER=base to BLOCK_TRANSFORMER=clique
But what client node are you using? @nnlgsakib

using polygon-edge

and its a bug please check it #1189 (comment)

image

i think bug on NEXT_PUBLIC_VIEWS_BLOCK_HIDDEN_FIELDS=['burnt_fees','total_reward']

but i add again NEXT_PUBLIC_VIEWS_BLOCK_HIDDEN_FIELDS=['burnt_fees','total_reward','nonce'] result from image

check this code

image

@ekawibisono
Copy link

I don't think this is a bug, maybe you didn't add enough 'nonce'. But back to team blockscout, whether it's a bug or not.

@tom2drum
Copy link
Collaborator

I definitely see the problem with the layout in some scenarios. So it is a bug.

@ekawibisono
Copy link

I definitely see the problem with the layout in some scenarios. So it is a bug.

Maybe the problem is on the part of the Special Hidden Block

tom2drum added a commit that referenced this issue Sep 21, 2023
@tom2drum tom2drum linked a pull request Sep 21, 2023 that will close this issue
tom2drum added a commit that referenced this issue Sep 25, 2023
tom2drum added a commit that referenced this issue Sep 25, 2023
* fix latest blocks layout issue

Fixes #1189

* remove hardcoded height for latest block item

* update homepage screenshots
@github-actions github-actions bot added pre-release Tasks in pre-release right now v1.12.0 Release v1.12.0 and removed pre-release Tasks in pre-release right now labels Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1.12.0 Release v1.12.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants