Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding capability to display alert/announcement in the new UI #1123

Closed
vbaranov opened this issue Aug 29, 2023 · 8 comments · Fixed by #1232
Closed

Allow adding capability to display alert/announcement in the new UI #1123

vbaranov opened this issue Aug 29, 2023 · 8 comments · Fixed by #1232
Assignees
Labels
v1.13.0 Release v1.13.0

Comments

@vbaranov
Copy link
Member

Description

In the old UI it is managed via SHOW_MAINTENANCE_ALERT (true/false) and MAINTENANCE_ALERT_MESSAGE is for HTML/text message.

Link to the page

https://eth.blockscout.com

Steps to reproduce

  1. Go to '...'
  2. Click on '...'
  3. Scroll down to '...'
  4. See error

App version

v.1.9.0

Browser

No response

Operating system

None

Additional information

No response

@vbaranov vbaranov added bug Something isn't working triage Issues and PRs that are needed triage labels Aug 29, 2023
@isstuev isstuev added the need design For issues that wait for design updates label Aug 29, 2023
@isstuev
Copy link
Collaborator

isstuev commented Aug 29, 2023

use gray alert to display that info

Image

@isstuev
Copy link
Collaborator

isstuev commented Aug 29, 2023

MAINTENANCE_ALERT_MESSAGE can contain plain text and links, we need to use some template format

@NikitaSavik NikitaSavik removed bug Something isn't working need design For issues that wait for design updates triage Issues and PRs that are needed triage labels Sep 25, 2023
@tom2drum
Copy link
Collaborator

@vbaranov can you provide an example value for MAINTENANCE_ALERT_MESSAGE for test purposes?

@vbaranov
Copy link
Member Author

@vbaranov can you provide an example value for MAINTENANCE_ALERT_MESSAGE for test purposes?

e.g.

The Sokol Testnet is currently lacking validators. Please consider using <a href="https://eth-goerli.blockscout.com/">Goerli</a> or <a href="https://mumbai.polygonscan.com/">Mumbai</a> for testing purposes.

@tom2drum
Copy link
Collaborator

@vbaranov is it OK if we use just one variable NEXT_PUBLIC_MAINTENANCE_ALERT_MESSAGE? If it is present, we will display the message.

@tom2drum tom2drum self-assigned this Sep 28, 2023
@vbaranov
Copy link
Member Author

@vbaranov is it OK if we use just one variable NEXT_PUBLIC_MAINTENANCE_ALERT_MESSAGE? If it is present, we will display the message.

Yeah, I think 1 env var would be pretty much it.

@tom2drum
Copy link
Collaborator

And what if we have two alerts to display for indexing blocks and for maintenance, should we show both, one below the other?

@vbaranov
Copy link
Member Author

And what if we have two alerts to display for indexing blocks and for maintenance, should we show both, one below the other?

Yep, one below the other sounds good.

tom2drum added a commit that referenced this issue Oct 2, 2023
…1232)

* Allow adding capability to display alert/announcement in the new UI

Fixes #1123

* fix tests
@github-actions github-actions bot added pre-release Tasks in pre-release right now v1.13.0 Release v1.13.0 and removed pre-release Tasks in pre-release right now labels Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.13.0 Release v1.13.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants