Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : Modify tenderduty dashboard status about tendermint bn254 pubkey type for union chain #75

Merged

Conversation

Jeongseup
Copy link
Contributor

Purpose

Personally, so many validators who is operating chains in cosmos-sdk based chains want to use tenderduty for alerting their own validator nodes' uptime or something.

However, Its funtionality is not matched with chains which will be using BN254 types key such as Union Chain.

Then, if you're a node operator in union testnet, you cannot see your node status like bottom.

Failure Examples

dashboard & uptime

image

logs

image

Because of it, I made a seond PR for tenderduty for modifying status and logs about tendermint. bn254 type and union chain.

I already knew it's not best way. But, It works!

If you have a better way, I would welcome to modify this PR. Thanks.

@Jeongseup
Copy link
Contributor Author

Jeongseup commented Dec 14, 2023

Explanation

  1. Using valcons address : this is for correct querying signing info for uptime status

Screenshot 2023-12-14 at 1 52 43 PM

  1. Using status by json-rpc : this is for get correct status loop for drawing dashboard
    image

Can you check this PR? @dylanschultzie

@Jeongseup
Copy link
Contributor Author

Have you seen this error to build Dockerfile?

Dockerfile:3
--------------------
   1 |     # 1st stage, build app
   2 |     FROM golang:1.19 as builder
   3 | >>> RUN apt-get update && apt-get -y upgrade && apt-get install -y upx
   4 |     COPY . /build/app
   5 |     WORKDIR /build/app
--------------------
ERROR: failed to solve: process "/bin/sh -c apt-get update && apt-get -y upgrade && apt-get install -y upx" did not complete successfully: exit code: 100

@Jeongseup Jeongseup force-pushed the feature/support-bn254-pubkey branch from 076b6cb to 2fea9c4 Compare December 14, 2023 06:41
@dylanschultzie
Copy link
Collaborator

@Jeongseup pull the latest develop branch as there's a fix in it for that error. tl;dr: use FROM golang:1.20.6-bullseye as builder

@Jeongseup
Copy link
Contributor Author

Thanks ! and then, Do you think I need to do something for this PR?

@dylanschultzie
Copy link
Collaborator

dylanschultzie commented Dec 21, 2023

How are you using json-rpc for union? I don't see that available in the configs.

edit: nevermind

@dylanschultzie dylanschultzie merged commit 6471655 into blockpane:develop Dec 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants