fix: allow running the local scripts outside of the main FTL directory. #3017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, trying to run `~/Development/ftl/scripts/ftl dev` from a separate project failed with ``` error:controller0: error: No justfile found ``` After this, it builds the frontend correctly.
jvmakine
requested review from
a team and
deniseli
and removed request for
a team
Open
alecthomas
approved these changes
Oct 7, 2024
| @@ -24,7 +25,7 @@ var proxyURL, _ = url.Parse("http://localhost:5173") //nolint:errcheck | |||
| var proxy = httputil.NewSingleHostReverseProxy(proxyURL) | |||
|
|
|||
| func Server(ctx context.Context, timestamp time.Time, publicURL *url.URL, allowOrigin *url.URL) (http.Handler, error) { | |||
| gitRoot, ok := internal.GitRoot("").Get() | |||
| gitRoot, ok := internal.GitRoot(os.Getenv("FTL_DIR")).Get() | |||
There was a problem hiding this comment.
If you want to use an envar, plumb it through from a Kong config rather than using getenv directly
There was a problem hiding this comment.
Ah I see, this is local.go...disregard!
alecthomas
approved these changes
Oct 7, 2024
| @@ -24,7 +25,7 @@ var proxyURL, _ = url.Parse("http://localhost:5173") //nolint:errcheck | |||
| var proxy = httputil.NewSingleHostReverseProxy(proxyURL) | |||
|
|
|||
| func Server(ctx context.Context, timestamp time.Time, publicURL *url.URL, allowOrigin *url.URL) (http.Handler, error) { | |||
| gitRoot, ok := internal.GitRoot("").Get() | |||
| gitRoot, ok := internal.GitRoot(os.Getenv("FTL_DIR")).Get() | |||
There was a problem hiding this comment.
Ah I see, this is local.go...disregard!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, trying to run
~/Development/ftl/scripts/ftl devfrom a separate project failed withAfter this,
scripts/ftl devbuilds the console correctly, though the console UI still does not load correctly, due to