fix: optional handling in the JVM #2951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
requested review from
a team and
worstell
and removed request for
a team
stuartwdouglas
force-pushed
the
stuartwdouglas/2356
branch
2 times, most recently
from
29dfe85 to
9b199e8
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/2356
branch
from
9b199e8 to
d5bfba0
Compare
alecthomas
approved these changes
Oct 2, 2024
| return client.call(val); | ||
| } | ||
|
|
||
| @Export | ||
| @Verb | ||
| public byte[] optionalBytesVerb(byte[] val, OptionalBytesVerbClient client) { | ||
| public byte @Nullable [] optionalBytesVerb(byte @Nullable [] val, OptionalBytesVerbClient client) { |
There was a problem hiding this comment.
Is this the typical place for an annotation on an array?!
There was a problem hiding this comment.
@Nullable Object[] is an array with nullable elements, Object @Nullable [] is an array that can be null.
It's very weird syntax and not very common, you generally don't want nullable arrays anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Kotlin this should exactly match the language semantics. For Java types are not considered Optional unless they are wrapped in a java.util.Optional, or annotated with @nullable.
The exception to this are the boxed primitive types, which are always considered nullable.
fixes: #2356