feat: use JavaDoc as comments #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
requested review from
a team and
matt2e
and removed request for
a team
Open
This is a very basic PoC implementation that can serve as a base for further work. fixes: 2417
stuartwdouglas
force-pushed
the
stuartwdouglas/java-annotations
branch
from
b33fcd8 to
2ef070e
Compare
matt2e
approved these changes
Aug 22, 2024
alecthomas
reviewed
Aug 23, 2024
| @@ -82,9 +82,11 @@ public class ModuleBuilder { | |||
| private final Map<DotName, TopicsBuildItem.DiscoveredTopic> knownTopics; | |||
| private final Map<DotName, VerbClientBuildItem.DiscoveredClients> verbClients; | |||
| private final FTLRecorder recorder; | |||
| private final Map<String, String> verbDocs; | |||
There was a problem hiding this comment.
Just to make sure you know, most declarations in the FTL schema can include comments - data structures, enums, etc.
| /** | ||
| * POC annotation processor for capturing JavaDoc, this needs a lot more work. | ||
| */ | ||
| public class AnnotationProcessor implements Processor { |
There was a problem hiding this comment.
Does this run as part of the module JVM instance, or as part of the build?
|
This is awesome. |
This was referenced Aug 27, 2024
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very basic PoC implementation that can serve as a base for further work.