From e5ef803f3fb0c4e42f34db811ac59a2d564baf77 Mon Sep 17 00:00:00 2001 From: Denise Li Date: Tue, 20 Aug 2024 16:54:54 -0400 Subject: [PATCH 1/3] add titles to truncated columns --- frontend/src/features/timeline/TimelineCall.tsx | 3 ++- frontend/src/features/timeline/TimelineDeploymentCreated.tsx | 5 +++-- frontend/src/features/timeline/TimelineDeploymentUpdated.tsx | 5 +++-- frontend/src/features/timeline/TimelineLog.tsx | 2 +- 4 files changed, 9 insertions(+), 6 deletions(-) diff --git a/frontend/src/features/timeline/TimelineCall.tsx b/frontend/src/features/timeline/TimelineCall.tsx index 361e795dba..75e14ce0e8 100644 --- a/frontend/src/features/timeline/TimelineCall.tsx +++ b/frontend/src/features/timeline/TimelineCall.tsx @@ -2,8 +2,9 @@ import type { CallEvent } from '../../protos/xyz/block/ftl/v1/console/console_pb import { verbRefString } from '../verbs/verb.utils' export const TimelineCall = ({ call }: { call: CallEvent }) => { + const title = `${call.sourceVerbRef?.module ? `${verbRefString(call.sourceVerbRef)} -> ` : ''}${verbRefString(call.destinationVerbRef)}`; return ( - + {call.sourceVerbRef?.module && ( <> {verbRefString(call.sourceVerbRef)} diff --git a/frontend/src/features/timeline/TimelineDeploymentCreated.tsx b/frontend/src/features/timeline/TimelineDeploymentCreated.tsx index 1bee4632d7..a3a4f879a4 100644 --- a/frontend/src/features/timeline/TimelineDeploymentCreated.tsx +++ b/frontend/src/features/timeline/TimelineDeploymentCreated.tsx @@ -1,10 +1,11 @@ import type { DeploymentCreatedEvent } from '../../protos/xyz/block/ftl/v1/console/console_pb' export const TimelineDeploymentCreated = ({ deployment }: { deployment: DeploymentCreatedEvent }) => { + const title = `Created deployment ${deployment.key} for language ${deployment.language}` return ( - <> + Created deployment {deployment.key} for language{' '} {deployment.language} - + ) } diff --git a/frontend/src/features/timeline/TimelineDeploymentUpdated.tsx b/frontend/src/features/timeline/TimelineDeploymentUpdated.tsx index 110b7a3011..79b89b452f 100644 --- a/frontend/src/features/timeline/TimelineDeploymentUpdated.tsx +++ b/frontend/src/features/timeline/TimelineDeploymentUpdated.tsx @@ -1,11 +1,12 @@ import type { DeploymentUpdatedEvent } from '../../protos/xyz/block/ftl/v1/console/console_pb' export const TimelineDeploymentUpdated = ({ deployment }: { deployment: DeploymentUpdatedEvent }) => { + const title = `Updated deployment ${deployment.key} min replicas to ${deployment.minReplicas} (previously ${deployment.prevMinReplicas})` return ( - <> + Updated deployment {deployment.key} min replicas to{' '} {deployment.minReplicas} (previously{' '} {deployment.prevMinReplicas}) - + ) } diff --git a/frontend/src/features/timeline/TimelineLog.tsx b/frontend/src/features/timeline/TimelineLog.tsx index 91b6961320..77b05b1d99 100644 --- a/frontend/src/features/timeline/TimelineLog.tsx +++ b/frontend/src/features/timeline/TimelineLog.tsx @@ -1,5 +1,5 @@ import type { LogEvent } from '../../protos/xyz/block/ftl/v1/console/console_pb' export const TimelineLog = ({ log }: { log: LogEvent }) => { - return {log.message} + return {log.message} } From a6a98655bb82221cf6e02f06433bd41c72d8bb10 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Tue, 20 Aug 2024 21:00:48 +0000 Subject: [PATCH 2/3] chore(autofmt): Automated formatting --- frontend/src/features/timeline/TimelineCall.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/src/features/timeline/TimelineCall.tsx b/frontend/src/features/timeline/TimelineCall.tsx index 75e14ce0e8..06d5bb8390 100644 --- a/frontend/src/features/timeline/TimelineCall.tsx +++ b/frontend/src/features/timeline/TimelineCall.tsx @@ -2,7 +2,7 @@ import type { CallEvent } from '../../protos/xyz/block/ftl/v1/console/console_pb import { verbRefString } from '../verbs/verb.utils' export const TimelineCall = ({ call }: { call: CallEvent }) => { - const title = `${call.sourceVerbRef?.module ? `${verbRefString(call.sourceVerbRef)} -> ` : ''}${verbRefString(call.destinationVerbRef)}`; + const title = `${call.sourceVerbRef?.module ? `${verbRefString(call.sourceVerbRef)} -> ` : ''}${verbRefString(call.destinationVerbRef)}` return ( {call.sourceVerbRef?.module && ( From 1bc7d393bbab819d103a5c53037758d4841c030a Mon Sep 17 00:00:00 2001 From: Denise Li Date: Tue, 20 Aug 2024 17:08:12 -0400 Subject: [PATCH 3/3] fix test --- frontend/src/features/timeline/TimelineCall.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/src/features/timeline/TimelineCall.tsx b/frontend/src/features/timeline/TimelineCall.tsx index 06d5bb8390..e371081a05 100644 --- a/frontend/src/features/timeline/TimelineCall.tsx +++ b/frontend/src/features/timeline/TimelineCall.tsx @@ -2,7 +2,7 @@ import type { CallEvent } from '../../protos/xyz/block/ftl/v1/console/console_pb import { verbRefString } from '../verbs/verb.utils' export const TimelineCall = ({ call }: { call: CallEvent }) => { - const title = `${call.sourceVerbRef?.module ? `${verbRefString(call.sourceVerbRef)} -> ` : ''}${verbRefString(call.destinationVerbRef)}` + const title = `${call.sourceVerbRef?.module ? `${verbRefString(call.sourceVerbRef)} -> ` : ''}${call.destinationVerbRef ? verbRefString(call.destinationVerbRef) : ''}` return ( {call.sourceVerbRef?.module && (