Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ftl dev doesn't rebuild failed modules when their dependencies succeed #936

Closed
wesbillman opened this issue Feb 14, 2024 · 0 comments
Closed
Assignees

Comments

@wesbillman
Copy link
Collaborator

With echo and time, echo should fail to build if time isn't deployed, which it did. But once time deployed successfully, echo never tried to rebuild again, so the command was hung until another change was detected or it was restarted. Here's the log:

ftl dev go

info: Building go module 'echo'
error: Error deploying module /Users/wesbillman/dev/ftl/examples/go/echo. Will retry: failed to build module: failed to extract module schema: /Users/wesbillman/dev/ftl/examples/go/echo/echo.go:4:1: /Users/wesbillman/dev/ftl/examples/go/echo/echo.go:27:1: /Users/wesbillman/dev/ftl/examples/go/echo/echo.go:27:71: /Users/wesbillman/dev/ftl/examples/go/echo/echo.go:29:2: /Users/wesbillman/dev/ftl/examples/go/echo/echo.go:29:16: call first argument must be a function but is an unresolved reference to time.Time
info: Building go module 'time'
go: module . listed in go.work file requires go >= 1.22.0, but go.work lists go 1.21.6; to update it:
	go work use
error: Error deploying module /Users/wesbillman/dev/ftl/examples/go/time. Will retry: failed to build module: exit status 1
info: Building go module 'echo'
error: Error deploying module /Users/wesbillman/dev/ftl/examples/go/echo. Will retry: failed to build module: failed to extract module schema: /Users/wesbillman/dev/ftl/examples/go/echo/echo.go:4:1: /Users/wesbillman/dev/ftl/examples/go/echo/echo.go:27:1: /Users/wesbillman/dev/ftl/examples/go/echo/echo.go:27:71: /Users/wesbillman/dev/ftl/examples/go/echo/echo.go:29:2: /Users/wesbillman/dev/ftl/examples/go/echo/echo.go:29:16: call first argument must be a function but is an unresolved reference to time.Time
info: Building go module 'time'
go: module . listed in go.work file requires go >= 1.22.0, but go.work lists go 1.21.6; to update it:
	go work use
error: Error deploying module /Users/wesbillman/dev/ftl/examples/go/time. Will retry: failed to build module: exit status 1
warn: Detected change in file /Users/wesbillman/dev/ftl/examples/go/time/go.mod
info: Building go module 'time'
info: Successfully built module 'time' in 2.87s
info: Preparing module 'time' for deployment
info: Successfully created deployment time-f7a182361c

At this point, I would have expected echo to attempt to build.

@github-actions github-actions bot added the triage Issue needs triaging label Feb 14, 2024
@alecthomas alecthomas self-assigned this Feb 14, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants