Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ftl init create completely self-contained modules #933

Closed
alecthomas opened this issue Feb 13, 2024 · 0 comments · Fixed by #1005
Closed

Make ftl init create completely self-contained modules #933

alecthomas opened this issue Feb 13, 2024 · 0 comments · Fixed by #1005
Labels
good first issue Good for newcomers next Work that will be be picked up next usability Usability issue

Comments

@alecthomas
Copy link
Collaborator

Currently in both languages the init command creates a parent directory containing a pom.xml for Kotlin and a go.mod for Go. This is unnecessary and annoying.
@alecthomas alecthomas added the usability Usability issue label Feb 13, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Feb 13, 2024
@alecthomas alecthomas mentioned this issue Feb 13, 2024
Open
@alecthomas alecthomas added good first issue Good for newcomers next Work that will be be picked up next labels Feb 13, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Feb 13, 2024
worstell added a commit that referenced this issue Mar 2, 2024
@worstell
chore: make ftl init create self contained kotlin modules
ba2cab0 
fixes #933
worstell added a commit that referenced this issue Mar 2, 2024
@worstell
chore: make ftl init create self contained kotlin modules
921ed41 
fixes #933
worstell added a commit that referenced this issue Mar 2, 2024
@worstell
chore: make ftl init create self contained kotlin modules
aa99ca4 
fixes #933
worstell added a commit that referenced this issue Mar 2, 2024
@worstell
chore: make ftl init create self contained kotlin modules
259f6e3 
fixes #933
worstell added a commit that referenced this issue Mar 2, 2024
@worstell
chore: make ftl init create self contained kotlin modules
9164fd4 
fixes #933
@worstell worstell mentioned this issue Mar 2, 2024
Merged
worstell added a commit that referenced this issue Mar 2, 2024
@worstell @github-actions
chore: make ftl init create self contained kotlin modules (#1005)
208c3aa 
- removes parent POM + logic to update parent POM when new child POMs
are added; each module has its own self-contained POM now
- removes now unused`ftlEndpoint` and `ftlModuleName` maven properties
- removes the `ftl-module-` prefix from kotlin module scaffolding

fixes #933

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers next Work that will be be picked up next usability Usability issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: make ftl init create self contained kotlin modules block/ftl
1 participant
@alecthomas