Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribers skip messages on module upgrade #3808

Closed
matt2e opened this issue Dec 18, 2024 · 2 comments · Fixed by #3811
Closed

Subscribers skip messages on module upgrade #3808

matt2e opened this issue Dec 18, 2024 · 2 comments · Fixed by #3811
Assignees

Comments

@matt2e
Copy link
Collaborator

matt2e commented Dec 18, 2024

Steps to repro:

  • Have a module with a subscriber with no retry policy that is trying to get through a backlog of messages
  • Deploy a newer version of the module

What goes wrong:

  • The context gets cancelled which fails any active calls
  • These failures are not detected any differently than other errors, and so we commit these messages as having been processed
  • Then sarama closes the consumer group, which includes sending all the commits to kafka
@matt2e matt2e self-assigned this Dec 18, 2024
@stuartwdouglas
Copy link
Collaborator

I think this is part of the more general problem of request draining.

@matt2e
Copy link
Collaborator Author

matt2e commented Dec 18, 2024

I played around with the code, and i think it is, but also there were some underlying problems with how the consumer code handled context cancellation. This issue ended up also happening each time the consumer group was rebalanced for whatever reason.
Fixed in the PR linked above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants