Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rate limit and batch new events when publishing to timeline #3671

Closed
matt2e opened this issue Dec 8, 2024 · 0 comments · Fixed by #3683
Closed

Rate limit and batch new events when publishing to timeline #3671

matt2e opened this issue Dec 8, 2024 · 0 comments · Fixed by #3683
Assignees
@matt2e

Comments

@matt2e
Copy link
Collaborator

matt2e commented Dec 8, 2024

No description provided.

@matt2e matt2e self-assigned this Dec 8, 2024
@ftl-robot ftl-robot mentioned this issue Dec 8, 2024
Open
@matt2e matt2e mentioned this issue Dec 9, 2024
Merged
matt2e added a commit that referenced this issue Dec 9, 2024
@matt2e @github-actions
feat: stream events to timeline service in batches (#3683)
4c88c60 
- Each timeline client now batches events to publish to timeline service
- Timeline service no longer guarantees that events are in time order.
- Steaming fixes:
    - Streaming now uses event id for paging
- Streaming now works when order is set to descending (each batch is
identical to ascending now, but in reverse order)
- Added integration test to ensure streaming works with the paging logic

closes [Rate limit and batch new events when publishing to timeline
#3671](#3671)

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matt2e matt2e

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: stream events to timeline service in batches block/ftl
1 participant
@matt2e