Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move backend/controller/timeline tests to new service #3634

Closed
matt2e opened this issue Dec 5, 2024 · 0 comments · Fixed by #3667
Closed

Move backend/controller/timeline tests to new service #3634

matt2e opened this issue Dec 5, 2024 · 0 comments · Fixed by #3667

Comments

@matt2e
Copy link
Collaborator

matt2e commented Dec 5, 2024

No description provided.

@matt2e matt2e self-assigned this Dec 5, 2024
@ftl-robot ftl-robot mentioned this issue Dec 5, 2024
Open
@matt2e matt2e mentioned this issue Dec 6, 2024
Merged
matt2e added a commit that referenced this issue Dec 6, 2024
@matt2e
feat: publish timeline events with new service (#3649)
72efa87 
Timeline event publishing happens with convenience func:
`timeline.Publish(ctx, event)`, and all event creation is moved over to
it.

Timeline tests have been in this PR but [will come back
soon](#3634).

This PR is split from #3639.
Thanks @worstell for working on this one with me.

closes #3622
@matt2e matt2e removed their assignment Dec 6, 2024
worstell added a commit that referenced this issue Dec 7, 2024
@worstell
chore: publish timeline events from cron + integration tests
4973e06 
fixes #3634
fixes #3654
@worstell worstell mentioned this issue Dec 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: publish timeline events from cron + integration tests block/ftl
1 participant
@matt2e