Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate log lines printed for cron, pubsub #2962

Closed
safeer opened this issue Oct 2, 2024 · 2 comments · Fixed by #2990
Closed

Duplicate log lines printed for cron, pubsub #2962

safeer opened this issue Oct 2, 2024 · 2 comments · Fixed by #2990
Assignees
Labels
core The core of FTL

Comments

@safeer
Copy link
Contributor

safeer commented Oct 2, 2024

Unsure if these are being executed twice or the logs just printed twice. Cron dupes visible in the console UI as well

Screenshot 2024-10-02 at 1 48 13 PM
@github-actions github-actions bot added the triage Issue needs triaging label Oct 2, 2024
@ftl-robot ftl-robot mentioned this issue Oct 2, 2024
@safeer safeer self-assigned this Oct 2, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Oct 2, 2024
@wesbillman
Copy link
Collaborator

I noticed similar behavior with logs as well:

info:cron: Hourly cron job triggered.
info:cron: Hourly cron job triggered.
info:cron: Frequent cron job triggered.
info:cron: Frequent cron job triggered.

@stuartwdouglas
Copy link
Collaborator

It's probably https://github.com/TBD54566975/ftl/pull/2919/files#diff-7a9ce4f8939ac436a713cd221b245a4e6465380d99d5834de728e23b09106590R444

I was thinking that we should have the errors in the pod logs as well as being sent back to the deployment logger, but for local dev that results in duplication.

@safeer safeer removed their assignment Oct 3, 2024
@safeer safeer added the triage Issue needs triaging label Oct 3, 2024
@matt2e matt2e added next Work that will be be picked up next core The core of FTL and removed triage Issue needs triaging labels Oct 3, 2024
@github-actions github-actions bot removed the next Work that will be be picked up next label Oct 3, 2024
stuartwdouglas added a commit that referenced this issue Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core The core of FTL
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants