Deployment getting REMOVED right after it gets ADDED

[wesbillman]

I noticed that deployments were disappearing in the console so started to look into why. Looking at the logs from notify.go it seems like we get into a state where we remove a deployment right after it gets added.

This is reproducible on main with the following steps

1. run ftl dev --recreate to deploy time, echo, cron
2. after the deploys complete make a change to echo.go to add a verb or something to trigger a new deployment
3. after that deploys, change echo.go back to it's original and notice that it gets removed right after getting added

I think the state of the db is ok, it's just that these notifications and/or the PullSchema code is notifying a removal

ftl dev --recreate
info: Starting FTL with 1 controller(s)
info:controller0: Web console available at: http://localhost:8892
info:controller0: HTTP ingress server listening on: http://127.0.0.1:8891
info: Controller started in 1.004536125s
info: FTL startup command ⚡️
info:time:build: Building module
info:cron:build: Building module
info:time:build: Module built (3.65s)
info:time:deploy: Deploying module
info:cron:build: Module built (3.65s)
info:cron:deploy: Deploying module
warn:controller0: New deployment: time
info:echo:build: Building module
warn:controller0: New deployment: cron
info:controller0: Deployed dpl-time-1jdsso705ept9mgt
info:controller0: Deployed dpl-cron-3m29rgxgxn8r2cr9
info:echo:build: Module built (3.34s)
info:echo:deploy: Deploying module
warn:controller0: New deployment: echo
info:controller0: Deployed dpl-echo-4nyjaf4d17xcp362
info: All modules deployed in 13.95s, watching for changes...
info:echo:build: Building module
info:echo:build: Module built (2.71s)
info:echo:deploy: Deploying module
warn:controller0: New deployment: echo
info:controller0: Deployed dpl-echo-2pwai4p2t7nywfrt
warn:controller0: Removed deployment: dpl-echo-4nyjaf4d17xcp362
info:echo:build: Building module
info:echo:build: Module built (3.88s)
info:echo:deploy: Deploying module
info:cron: Frequent cron job triggered.
info:cron: Frequent cron job triggered.
warn:controller0: New deployment: echo
info:controller0: Deployed dpl-echo-4nyjaf4d17xcp362
warn:controller0: Removed deployment: dpl-echo-4nyjaf4d17xcp362

Specifically, the last 2 lines here show Deployed dpl-echo-4nyjaf4d17xcp362 followed by Removed deployment: dpl-echo-4nyjaf4d17xcp362