Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include serialization in ftltest #2934

Closed
worstell opened this issue Oct 1, 2024 · 3 comments
Closed

include serialization in ftltest #2934

worstell opened this issue Oct 1, 2024 · 3 comments
Assignees
@worstell

Comments

@worstell
Copy link
Contributor

worstell commented Oct 1, 2024

No description provided.

@worstell worstell self-assigned this Oct 1, 2024
@ftl-robot ftl-robot mentioned this issue Oct 1, 2024
Open
@alecthomas
Copy link
Collaborator

What's the purpose of doing this for the user?

It sounds like the problem is we don't have enough test coverage in FTL itself.

@stuartwdouglas
Copy link
Collaborator

With external types they could have custom serialization logic. If we don't serialize those paths never actually get tested.

@alecthomas
Copy link
Collaborator

Ah, good point, makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@worstell worstell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alecthomas @stuartwdouglas @worstell