You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Broken PR: #2891
This PR tries to upgrade @bufbuild/protoc-gen-es from 1.10.0 to 2.1.0, which depends on bufbuild/protobuf. Tests fails at:
cd backend/protos && buf generate
node:internal/modules/cjs/loader:646
throw e;
^
Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './reflect' is not defined by "exports" in /home/runner/work/ftl/ftl/node_modules/.pnpm/@[email protected]_@[email protected]/node_modules/@bufbuild/protobuf/package.json
at exportsNotFound (node:internal/modules/esm/resolve:296:10)
at packageExportsResolve (node:internal/modules/esm/resolve:643:9)
at resolveExports (node:internal/modules/cjs/loader:[63](https://github.com/TBD54566975/ftl/actions/runs/11115028397/job/30882695122?pr=2891#step:7:64)9:36)
at Module._findPath (node:internal/modules/cjs/loader:747:31)
at Module._resolveFilename (node:internal/modules/cjs/loader:1234:27)
at Module._load (node:internal/modules/cjs/loader:1074:27)
at TracingChannel.traceSync (node:diagnostics_channel:315:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
at Module.require (node:internal/modules/cjs/loader:1339:12)
at require (node:internal/modules/helpers:135:16) {
code: 'ERR_PACKAGE_PATH_NOT_EXPORTED'
}
If you pull down this branch and look at frontend/console/node_modules/@bufbuild/protobuf/package.json, the "exports" field indeed does not include ./reflect. However, if you look at their package.json on the npm website, it does indeed include ./reflect.
We shouldn't just pin the version if the external one really doesn't have the issue; we should figure out why we're somehow pulling down the wrong package.json.
The text was updated successfully, but these errors were encountered:
@deniseli I think the issue might have been that we were using a newer version of the protobuf stuff than connect-es is ready for. I looked at their example docs and repo and they are still on the ^1.0.0 track. So I updated the renovate PR to match their example packages here: https://github.com/connectrpc/connect-es/blob/main/packages/example/package.json which should resolve the issue and make sure we're using compatible packages.
Broken PR: #2891
This PR tries to upgrade
@bufbuild/protoc-gen-es
from1.10.0
to2.1.0
, which depends onbufbuild/protobuf
. Tests fails at:If you pull down this branch and look at
frontend/console/node_modules/@bufbuild/protobuf/package.json
, the"exports"
field indeed does not include./reflect
. However, if you look at their package.json on the npm website, it does indeed include./reflect
.We shouldn't just pin the version if the external one really doesn't have the issue; we should figure out why we're somehow pulling down the wrong
package.json
.The text was updated successfully, but these errors were encountered: