Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rollback of deployment updates #2886

Open
stuartwdouglas opened this issue Sep 29, 2024 · 0 comments
Open

Support rollback of deployment updates #2886

stuartwdouglas opened this issue Sep 29, 2024 · 0 comments
Labels
backlog Not pressing, but should be looked at someday

Comments

@stuartwdouglas
Copy link
Collaborator

We should support rolling back deployment updates. We need to be careful with schema compatibility though, if this new update has changed the schema the old deployment may not be considered compatible and more (e.g. a new field has been added, and the removal via rollback would be considered an incompatible change).

#2837 could be used as a building block to implement this, if we know exactly what versions of a given deployment anther deployment was compiled against we could use this to figure out which existing deployments are compatible with the old version, and which also need to be rolled back.

We also need to think about deployment sets, e.g. the PFI is multiple deployments, but they are all released from the same git commit, and I don't know if it would make sense to roll back some of the modules but not others.

There is a quite a lot of complexity here, but we probably want at least basic support for production usage.

@github-actions github-actions bot added the triage Issue needs triaging label Sep 29, 2024
@ftl-robot ftl-robot mentioned this issue Sep 29, 2024
@stuartwdouglas stuartwdouglas changed the title Support rolling back of deployment updates Support rollback of deployment updates Sep 30, 2024
@gak gak added backlog Not pressing, but should be looked at someday and removed triage Issue needs triaging labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Not pressing, but should be looked at someday
Projects
None yet
Development

No branches or pull requests

2 participants