Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestDiscoverModules is flaky #2870

Closed
alecthomas opened this issue Sep 27, 2024 · 0 comments · Fixed by #2872
Closed

TestDiscoverModules is flaky #2870

alecthomas opened this issue Sep 27, 2024 · 0 comments · Fixed by #2872
Labels
bug Something isn't working techdebt Issue is technical debt triage Issue needs triaging

Comments

@alecthomas
Copy link
Collaborator 

=== Failed
=== FAIL: internal/buildengine TestDiscoverModules (0.02s)
    /home/runner/work/ftl/ftl/internal/buildengine/discover_test.go:169: Expected values to be equal:
                 "**/*.go",
                 "go.mod",
                 "go.sum",
        -        "../../../../go-runtime/ftl/**/*.go",
                 "../../../../go-runtime/schema/testdata/**/*.go",
        +        "../../../../go-runtime/ftl/**/*.go",
               },
             },
           },

DONE 537 tests, 1 skipped, 1 failure in 253.[81](https://github.com/TBD54566975/ftl/actions/runs/11065222316/job/30744265259?pr=2867#step:6:82)4s
Error: === RUN   TestDiscoverModules
    internal/buildengine/discover_test.go:169: Expected values to be equal:
                 "**/*.go",
                 "go.mod",
                 "go.sum",
        -        "../../../../go-runtime/ftl/**/*.go",
                 "../../../../go-runtime/schema/testdata/**/*.go",
        +        "../../../../go-runtime/ftl/**/*.go",
               },
             },
           },
--- FAIL: TestDiscoverModules (0.02s)
@alecthomas alecthomas added bug Something isn't working techdebt Issue is technical debt labels Sep 27, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Sep 27, 2024
@ftl-robot ftl-robot mentioned this issue Sep 27, 2024
Open
@alecthomas alecthomas mentioned this issue Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working techdebt Issue is technical debt triage Issue needs triaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fix TestDiscoverModules flakiness block/ftl
1 participant
@alecthomas