Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StatusManager is truncating output on termination #2866

Closed
alecthomas opened this issue Sep 27, 2024 · 0 comments · Fixed by #2909
Closed

StatusManager is truncating output on termination #2866

alecthomas opened this issue Sep 27, 2024 · 0 comments · Fixed by #2909
Assignees
@stuartwdouglas
Labels
bug Something isn't working

Comments

@alecthomas
Copy link
Collaborator

alecthomas commented Sep 27, 2024 •
edited
Loading

I suspect it isn't correctly flushing the output/log buffers before exiting.

Note that the output randomly includes a subset of the output:

image

When running with --plain the output is always correct:

image
@alecthomas alecthomas added the bug Something isn't working label Sep 27, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Sep 27, 2024
@ftl-robot ftl-robot mentioned this issue Sep 27, 2024
Open
@stuartwdouglas stuartwdouglas self-assigned this Sep 29, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Sep 29, 2024
stuartwdouglas added a commit that referenced this issue Sep 30, 2024
@stuartwdouglas
fix: FTL truncating output
58a95a1 
This fixes the most common cases of this, but it still could happen if os.Exit
is called elsewhere.

Fixes #2866
@stuartwdouglas stuartwdouglas mentioned this issue Sep 30, 2024
Merged
stuartwdouglas added a commit that referenced this issue Sep 30, 2024
@stuartwdouglas
fix: FTL truncating output
2cba637 
This fixes the most common cases of this, but it still could happen if os.Exit
is called elsewhere.

Fixes #2866
stuartwdouglas added a commit that referenced this issue Oct 1, 2024
@stuartwdouglas
fix: FTL truncating output (#2909)
69c8505 
This fixes the most common cases of this, but it still could happen if
os.Exit is called elsewhere.

Fixes #2866
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuartwdouglas stuartwdouglas

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: FTL truncating output block/ftl
2 participants
@alecthomas @stuartwdouglas