Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up a new console endpoint to eventually serve both useModules and useSchema console use cases #2805

Closed
deniseli opened this issue Sep 24, 2024 · 1 comment · Fixed by #3064
Assignees
Labels
console Web console dx

Comments

@deniseli
Copy link
Contributor

Currently, we have two separate endpoints, one on the console service and one on the controller service, that both provide most of the data we need. We can't standardize to just one of those two because they're each missing data that only the other contains. We should just build a new endpoint that actually includes everything, formatted correctly, so we don't need to do this going forward.

Also, the new one needs to include the builtin module.

@deniseli deniseli added console Web console dx labels Sep 24, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Sep 24, 2024
@deniseli deniseli self-assigned this Sep 24, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Sep 24, 2024
This was referenced Sep 24, 2024
@wesbillman
Copy link
Collaborator

We'll probably want a dedicated StreamModules rpc in console service so we can live update the tree and the rest of the app as needed.

That might look something like this, and would replace PullSchema (which lives on the controller service now).

rpc StreamModules(StreamModulesRequest) returns (stream StreamModulesResponse);

The response here would be lighter weight than the PullSchema since we only really need enough data to build the module tree and provide data to dedicated decl pages. This will also let us control what the Module looks like to the frontend.

deniseli added a commit that referenced this issue Oct 3, 2024
Part 1 of #2805

Next:
1. Client side integration for this PR's version of StreamModules, which
behaves in a way that's very similar to the existing `get` endpoint
2. Address the TODO in StreamModules: detect + push deployment updates
to the stream
3. Handle streaming updates on the client side

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
console Web console dx
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants