Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java enum is schema extracted as data #2787

Closed
tomdaffurn opened this issue Sep 23, 2024 · 2 comments
Closed

Java enum is schema extracted as data #2787

tomdaffurn opened this issue Sep 23, 2024 · 2 comments
Assignees
@tomdaffurn
Labels
bug Something isn't working jvm

Comments

@tomdaffurn
Copy link
Contributor

Java enum classes are turned into schema type data. Special handling is needed to detect Enums as distinct from Classes:

https://github.com/TBD54566975/ftl/blob/06a05f540f0735958c4839a9ebce1b71cdbb6eb4/jvm-runtime/ftl-runtime/common/deployment/src/main/java/xyz/block/ftl/deployment/ModuleBuilder.java#L296

Should use info.isEnum()
@tomdaffurn tomdaffurn added bug Something isn't working jvm labels Sep 23, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Sep 23, 2024
This was referenced Sep 23, 2024
Open
Open
@tomdaffurn tomdaffurn self-assigned this Sep 23, 2024
@tomdaffurn tomdaffurn removed the triage Issue needs triaging label Sep 23, 2024
@stuartwdouglas
Copy link
Collaborator

There is an issue about adding support for enums here: #2514

@tomdaffurn
Copy link
Contributor Author

Dupe of #2514

@tomdaffurn tomdaffurn closed this as not planned Won't fix, can't repro, duplicate, stale Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomdaffurn tomdaffurn

Labels
bug Something isn't working jvm
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stuartwdouglas @tomdaffurn