Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on startup with otel enabled #2766

Closed
stuartwdouglas opened this issue Sep 22, 2024 · 0 comments · Fixed by #2767
Closed

Crash on startup with otel enabled #2766

stuartwdouglas opened this issue Sep 22, 2024 · 0 comments · Fixed by #2767
Labels
triage Issue needs triaging

Comments

@stuartwdouglas
Copy link
Collaborator

Running just otel-dev gives the following:

goroutine 29 [running]:
go.opentelemetry.io/otel/internal/global.(*registration).setDelegate(0x1400033c580, {0x10612ed00, 0x140007a8790})
        /Users/sdouglas/go/pkg/mod/go.opentelemetry.io/[email protected]/internal/global/meter.go:492 +0x19c
go.opentelemetry.io/otel/internal/global.(*meter).setDelegate(0x14000950990, {0x106106d68?, 0x140007ae3c0?})
        /Users/sdouglas/go/pkg/mod/go.opentelemetry.io/[email protected]/internal/global/meter.go:138 +0x1d8
go.opentelemetry.io/otel/internal/global.(*meterProvider).setDelegate(0x14000367f20, {0x106106d68, 0x140007ae3c0})
        /Users/sdouglas/go/pkg/mod/go.opentelemetry.io/[email protected]/internal/global/meter.go:47 +0x168
go.opentelemetry.io/otel/internal/global.SetMeterProvider.func1()
        /Users/sdouglas/go/pkg/mod/go.opentelemetry.io/[email protected]/internal/global/state.go:171 +0x3c
sync.(*Once).doSlow(0x0?, 0x1?)
        /Users/sdouglas/Library/Caches/hermit/pkg/go-1.23.1/src/sync/once.go:76 +0xf8
sync.(*Once).Do(...)
        /Users/sdouglas/Library/Caches/hermit/pkg/go-1.23.1/src/sync/once.go:67
go.opentelemetry.io/otel/internal/global.SetMeterProvider({0x106106d68, 0x140007ae3c0})
        /Users/sdouglas/go/pkg/mod/go.opentelemetry.io/[email protected]/internal/global/state.go:169 +0x1b4
go.opentelemetry.io/otel.SetMeterProvider(...)
        /Users/sdouglas/go/pkg/mod/go.opentelemetry.io/[email protected]/metric.go:41
github.com/TBD54566975/ftl/internal/observability.Init({0x106114490, 0x14000611680}, 0x0, {0x0, 0x0}, {0x105655d70, 0x9}, {0x10564bd4e, 0x3}, {0x104521120?, ...})
        /Users/sdouglas/go/src/github.com/TBD54566975/ftl/internal/observability/client.go:66 +0x704
main.(*serveCmd).run(0x107118340, {0x106114490, 0x14000611680}, {{0x1400014c4b0, 0x42}, {0x140005be208, 0x3}, {0x140003ce660, 0x0}, 0x140003ce6c0, ...}, ...)
        /Users/sdouglas/go/src/github.com/TBD54566975/ftl/frontend/cli/cmd_serve.go:98 +0x1d4
main.(*devCmd).Run.func1()
        /Users/sdouglas/go/src/github.com/TBD54566975/ftl/frontend/cli/cmd_dev.go:76 +0x60
golang.org/x/sync/errgroup.(*Group).Go.func1()
        /Users/sdouglas/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x54
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 1
        /Users/sdouglas/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x98

Disabling the DB instrumentation (or delaying it in a goroutine) seems to make this go away

@github-actions github-actions bot added the triage Issue needs triaging label Sep 22, 2024
@ftl-robot ftl-robot mentioned this issue Sep 22, 2024
stuartwdouglas added a commit that referenced this issue Sep 22, 2024
fixes: #2766
@stuartwdouglas stuartwdouglas changed the title Grash on startup with otel enabled Crash on startup with otel enabled Sep 22, 2024
stuartwdouglas added a commit that referenced this issue Sep 22, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
fixes: #2766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Issue needs triaging
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant