Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console module tree improvements #2760

Closed
3 tasks done
deniseli opened this issue Sep 20, 2024 · 2 comments · Fixed by #2859
Closed
3 tasks done

console module tree improvements #2760

deniseli opened this issue Sep 20, 2024 · 2 comments · Fixed by #2859
Assignees
@deniseli
Labels
console Web console dx

Comments

@deniseli
Copy link
Contributor

deniseli commented Sep 20, 2024 •
edited
Loading

  • dump headlessui disclosure button and make the expansion state externally controlled. This should fix the expansion state bugs
  • add top filters for decl type and substring match.
    • make sure modules with nothing inside them are handled in some reasonable way. Consider graying them out and/or sorting to the bottom of the list. Might not want to do these things if it makes the UI feel jumpy. Need to play around with it
@deniseli deniseli self-assigned this Sep 20, 2024
@deniseli deniseli added console Web console dx labels Sep 20, 2024
This was referenced Sep 20, 2024
Open
Open
@wesbillman
Copy link
Collaborator

For the top filters, I think the decl type filtering would be awesome! For the substring match, we should just check that it's useful given the global search we have now. If we decide it's still good to add, we can likely share fuzzy search logic between this filter and the global search :)

@deniseli
Copy link
Contributor Author

sweet sg!

@deniseli deniseli mentioned this issue Sep 24, 2024
Merged
deniseli added a commit that referenced this issue Sep 25, 2024
@deniseli
fix: console module tree: rip out disclosure button to fix all the st…
fb5c766 
…ate consistency bugs (#2811)

Part 1 of #2760
@deniseli deniseli mentioned this issue Sep 27, 2024
Merged
deniseli added a commit that referenced this issue Sep 27, 2024
@deniseli
feat: add decl type filter + collapse all button to console's module …
67f2db1 
…tree (#2859)

https://github.com/user-attachments/assets/a59c1b36-f9d1-4754-b29d-d2f8409fe882

Fixes: #2760
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deniseli deniseli

Labels
console Web console dx
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add decl type filter + collapse all button to console's module tree block/ftl
2 participants
@wesbillman @deniseli