Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console content overflow doesn't maintain dark mode #2698

Closed
mistermoe opened this issue Sep 16, 2024 · 0 comments · Fixed by #2709
Closed

Console content overflow doesn't maintain dark mode #2698

mistermoe opened this issue Sep 16, 2024 · 0 comments · Fixed by #2709
Assignees
Labels
bug Something isn't working console Web console dx

Comments

@mistermoe
Copy link
Collaborator

ftl-console-bug.mov
@github-actions github-actions bot added the triage Issue needs triaging label Sep 16, 2024
@ftl-robot ftl-robot mentioned this issue Sep 16, 2024
@wesbillman wesbillman added console Web console dx and removed triage Issue needs triaging labels Sep 16, 2024
@deniseli deniseli self-assigned this Sep 17, 2024
@deniseli deniseli added the bug Something isn't working label Sep 17, 2024
deniseli added a commit that referenced this issue Sep 17, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Fixes #2698

There were actually two underlying issues fixed here:
1. If you hard scroll down on any page in dark mode, the `<body>`
element would not respect dark mode, so you could still see white bg
underneath. That's gross. It's fixed now in `index.html`.
2. On the infrastructure page specifically, we never set the page body's
overflow behavior to scroll, so instead it would overflow the container.
Technically, with 1 fixed, you wouldn't even notice this issue, but it
was still worth fixing to future-proof the page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working console Web console dx
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants