Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redeploy failed to delete subscriptions #2655

Closed
stuartwdouglas opened this issue Sep 12, 2024 · 0 comments · Fixed by #2666
Closed

Redeploy failed to delete subscriptions #2655

stuartwdouglas opened this issue Sep 12, 2024 · 0 comments · Fixed by #2666
Labels
next Work that will be be picked up next

Comments

@stuartwdouglas
Copy link
Collaborator

PFI redeploy failed due to a failure to delete subscriptions:

Sep 12 12:18:45.426
ip-10-2-171-170.us-west-2.compute.internal-tbd-eks-cluster01
ftl-controller
Unary RPC failed: could not replace deployment: replace deployment failed willDeactivate trigger from dpl-tbdex-2s60uf14qoj7tzn8 to dpl-tbdex-3wwe0j1jflyndur3: could not delete old subscriptions: context canceled sql: transaction has already been committed or rolled back: /xyz.block.ftl.v1.ControllerService/ReplaceDeploy

Sep 12 12:18:45.426
ip-10-2-171-170.us-west-2.compute.internal-tbd-eks-cluster01
ftl-controller
Could not replace deployment: dpl-tbdex-3wwe0j1jflyndur3: replace deployment failed willDeactivate trigger from dpl-tbdex-2s60uf14qoj7tzn8 to dpl-tbdex-3wwe0j1jflyndur3: could not delete old subscriptions: context canceled sql: transaction has already been committed or rolled back

Sep 12 11:49:45.607
ip-10-2-171-170.us-west-2.compute.internal-tbd-eks-cluster01
ftl-controller
Deleted subscribers for dpl-tbdex-2s60uf14qoj7tzn8: subr-tbdex-orders-2mcikm2glnsmf1ky, subr-tbdex-rfqs-1977vy3nnyuyl0mn, subr-tbdex-handleTransactionEvents-45pg58ixsl84rlxc, subr-tbdex-outgoingMessages-126fq23e93a3u4yz

Note the large time gap between subscriber deletion and subscription deletion, it is likely some kind of lock issue.
@github-actions github-actions bot added the triage Issue needs triaging label Sep 12, 2024
@ftl-robot ftl-robot mentioned this issue Sep 12, 2024
Open
stuartwdouglas added a commit that referenced this issue Sep 12, 2024
@stuartwdouglas
fix: leaky transations on error
7fe502f 
If we are using the 'defer tx.CommitOrRollback(ctx, &err)' pattern
this will not roll back on error if the err variable has been
shadowed in a code block, as the outer err is not updated.

fixes #2655
stuartwdouglas added a commit that referenced this issue Sep 12, 2024
@stuartwdouglas
fix: leaky transactions on error
f58ec6a 
If we are using the 'defer tx.CommitOrRollback(ctx, &err)' pattern
this will not roll back on error if the err variable has been
shadowed in a code block, as the outer err is not updated.

fixes #2655
@stuartwdouglas stuartwdouglas mentioned this issue Sep 12, 2024
Closed
@jonathanj-square jonathanj-square added the next Work that will be be picked up next label Sep 12, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Sep 12, 2024
@stuartwdouglas stuartwdouglas mentioned this issue Sep 13, 2024
Merged
stuartwdouglas added a commit that referenced this issue Sep 13, 2024
@stuartwdouglas
fix: hang on redeployment
cdf4931 
fixes: #2655
stuartwdouglas added a commit that referenced this issue Sep 13, 2024
@stuartwdouglas
fix: hang on redeployment
ffa9cac 
fixes: #2655
github-merge-queue bot pushed a commit that referenced this issue Sep 13, 2024
@stuartwdouglas
fix: hang on redeployment (#2666)
429e5be 
fixes #2655
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
next Work that will be be picked up next
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: hang on redeployment block/ftl
fix: leaky transactions on error block/ftl
2 participants
@stuartwdouglas @jonathanj-square