Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treeview layout bug #2610

Closed
wesbillman opened this issue Sep 4, 2024 · 0 comments · Fixed by #2627
Closed

Treeview layout bug #2610

wesbillman opened this issue Sep 4, 2024 · 0 comments · Fixed by #2627
Assignees
Labels
bug Something isn't working console Web console dx

Comments

@wesbillman
Copy link
Collaborator

The highlighted item background doesn't fill all the way to the right when an exported badge is present. See below

We should probably truncate or find a way to make this layout look a bit more polished.

Screenshot 2024-09-04 at 8 53 10 AM

@wesbillman wesbillman added bug Something isn't working console Web console dx labels Sep 4, 2024
github-merge-queue bot pushed a commit that referenced this issue Sep 5, 2024
Fixes #2610

Issues fixed:
* The `export` icons:
* Used to compress to a smaller size when you resized the tree panel
smaller than the width of the decl's row. Now, the size is fixed.
  * Added on-hover text so users can find out what it means more easily.
* Panel resizing handle: 
  * Got rid of its background color so it's invisible until used
* Set the width back to its original 3px, which is easier to use and not
a problem now that it's invisible. I originally adjusted it down to 2px
to be less visually intrusive.
* Fixed the on-hover color in dark mode so it's always easy to latch
onto it now.
* Highlight color of each decl row would only extend as far as the
right-side border minus padding+margin. However, text would overflow
beyond that container limit. This PR makes the decl items full-width and
removes the rounded corners, so you can't see that the text is
overflowing.
* Removed several layers of elements in the tree wrapping that just
weren't necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working console Web console dx
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants