Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review the Page and Header components #2490

Closed
wesbillman opened this issue Aug 23, 2024 · 2 comments · Fixed by #3138
Closed

Review the Page and Header components #2490

wesbillman opened this issue Aug 23, 2024 · 2 comments · Fixed by #3138
Assignees
@wesbillman
Labels
console Web console dx

Comments

@wesbillman
Copy link
Collaborator

These were added in the old design, are they still useful?
@wesbillman wesbillman added console Web console dx labels Aug 23, 2024
This was referenced Aug 23, 2024
Open
Open
Open
Open
Open
Open
Open
Open
@deniseli deniseli mentioned this issue Aug 29, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 3, 2024
@deniseli
feat: delete Deployments tab, module tree uses old deployments compon…
8d0cdac 
…ents (#2560)

* Removes `Deployments` tab
* Removes all the extraneous page headers
(#2490)
* Fixes all the routing to point to `/modules/{moduleName}/...` instead
of `/deployments/{deploymentKey}/...`
* Minor cleanup of deployment components' internal logic after replacing
`deploymentKey` with `moduleName` in the outermost interface


https://github.com/user-attachments/assets/ad785b7c-3e88-4d8d-8edb-b14bed441c98
@deniseli
Copy link
Contributor

I'ma rip em out

@deniseli
Copy link
Contributor

Sending out the first PR removing Page.Header soon. I'll wait on removing the Page.Body component until after rewriting the module(s) pages, since those still use it, and I'd rather not refactor the CSS if I'm about to rip it all out anyway.

@deniseli deniseli mentioned this issue Sep 17, 2024
Merged
wesbillman pushed a commit that referenced this issue Sep 18, 2024
@deniseli @github-actions
chore: remove Page.Header console component (#2712)
2e719cf 
Part 1 of #2490

Deletes the `Page.Header` component, which is an artifact of a bygone
era.

Since the timeline page also had a time range filter embedded in the
header, I moved that over to the left-hand-side filter panel. It just
need a tiny bit of resizing to fit.

<img width="342" alt="Screenshot 2024-09-17 at 4 29 45 PM"
src="https://github.com/user-attachments/assets/5769f782-1407-45ba-a6be-bcd1515ad506">
<img width="371" alt="Screenshot 2024-09-17 at 4 36 51 PM"
src="https://github.com/user-attachments/assets/a9ad948c-eb07-4b4b-899d-47c15df56bbc">

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@wesbillman wesbillman assigned wesbillman and unassigned deniseli Oct 16, 2024
@wesbillman wesbillman mentioned this issue Oct 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wesbillman wesbillman

Labels
console Web console dx
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove page component and other unused code block/ftl
2 participants
@wesbillman @deniseli