Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish up tree view UI and logic #2487

Closed
7 tasks done
wesbillman opened this issue Aug 23, 2024 · 0 comments · Fixed by #2523
Closed
7 tasks done

Finish up tree view UI and logic #2487

wesbillman opened this issue Aug 23, 2024 · 0 comments · Fixed by #2523
Assignees
@deniseli
Labels
console Web console dx

Comments

@wesbillman
Copy link
Collaborator

wesbillman commented Aug 23, 2024 •
edited by deniseli
Loading

  • Validate the use of pullSchema for the backend driving this UI
  • Handle open and collapsed states correctly
  • Handle selected items (show them selected in the tree and show a child page for them)
  • Finish up look and feel
  • Refactor components
  • Make it expandable (resize width)
  • Make the module itself tappable. Maybe a button like encore has?
    Screenshot 2024-08-23 at 1 32 02 PM
@wesbillman wesbillman added console Web console dx labels Aug 23, 2024
@ftl-robot ftl-robot mentioned this issue Aug 23, 2024
Open
@wesbillman wesbillman mentioned this issue Aug 23, 2024
Open
This was referenced Aug 27, 2024
Open
Open
Open
Open
Open
Open
@deniseli deniseli mentioned this issue Aug 28, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 29, 2024
@deniseli
feat: add module tree with routing to basic decl pages (#2523)
9de38e9 
Fixes #2487

* New tree view
* Local storage persists the module expansion state and the width of the
tree
* Base page added for all decl types, with slightly more built out for
verb and data to show how it all hooks together



https://github.com/user-attachments/assets/36b9fb48-76ac-4fc7-aa34-54713675e462



Next: verb page code editor
@deniseli deniseli mentioned this issue Aug 29, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 29, 2024
@deniseli
feat: make the module tree scrollable + scroll to selected module (#2557
947cdff 
)

Final part of #2487



https://github.com/user-attachments/assets/eb7ed1eb-d8ae-4a92-b56e-7bde8aed3a6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deniseli deniseli

Labels
console Web console dx
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add module tree with routing to basic decl pages block/ftl
2 participants
@wesbillman @deniseli