generated from TBD54566975/tbd-project-template
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select code editor component and finalize UX #2458
Comments
Open
Open
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 21, 2024
Issue: #2458 Changes: * Response panel is only displayed when `Body` tab (i.e. Request tab) is selected, instead of taking screen real estate away from the read-only schema tabs * Border between request and response panels is replaced with a full-width draggable handle * Related: fixed the existing bugs in `components/ResizeableVerticalPanels.tsx` * All codemirror components automatically take the full height of their container https://github.com/user-attachments/assets/9594c696-1ddb-4412-bd13-722c73cd7662 --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 21, 2024
Fixes #2458 Before, tabbing would change the focus to the next element on the page. This adds the correct key binding so that hitting tab within the codemirror editor actually inserts 2 spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We are currently using Codemirror for our editor.
In the past we have used Monaco, which was great and maybe the best option for us, but had some layout/resizing issues that need to be solved.
Another great option is Ace editor.
A good example experience we should use as inspiration is the Rust Playground. The layout and resizing is seamless and I really like the way the output window appears after a request is sent.
The text was updated successfully, but these errors were encountered: