Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go ftltest package: allow "sub contexts" to be created #2393

Closed
alecthomas opened this issue Aug 15, 2024 · 0 comments · Fixed by #2535
Closed

Go ftltest package: allow "sub contexts" to be created #2393

alecthomas opened this issue Aug 15, 2024 · 0 comments · Fixed by #2535
Assignees
@jvmakine
Labels
good first issue Good for newcomers

Comments

@alecthomas
Copy link
Collaborator

Currently the context is constructed in a single call, which means that if a slight change to the context is needed - for example faking out a single verb - the entire context needs to be recreated.

It'd be useful if the context could be cloned with overrides, or perhaps switch to a builder pattern.
@github-actions github-actions bot added the triage Issue needs triaging label Aug 15, 2024
@ftl-robot ftl-robot mentioned this issue Aug 15, 2024
Open
@deniseli deniseli added good first issue Good for newcomers next Work that will be be picked up next and removed triage Issue needs triaging labels Aug 26, 2024
This was referenced Aug 27, 2024
Open
Open
Open
Open
Open
Open
Open
@jvmakine jvmakine self-assigned this Aug 27, 2024
@github-actions github-actions bot removed the next Work that will be be picked up next label Aug 27, 2024
@jvmakine jvmakine mentioned this issue Aug 29, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 29, 2024
@jvmakine
chore: support extending ftltest context with additional options (#2535)
d9745ae 
Adds a new `SubContext` function, that replays options from a previous
fakeFTL creation, appending new options to it.

Closes #2393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jvmakine jvmakine

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: support extending ftltest context with additional options block/ftl
3 participants
@alecthomas @jvmakine @deniseli